<div dir="ltr"><div>I added the option to choose to prioritized AUX or PWM before in last version of this patch set.</div><div>But comment from Jani said that it is better to separate the patch.</div><div>The option to prioritized the PWM in now in patch #4<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 8, 2017 at 10:55 AM, Pandiyan, Dhinakaran <span dir="ltr"><<a href="mailto:dhinakaran.pandiyan@intel.com" target="_blank">dhinakaran.pandiyan@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote:<br>
> intel_dp_aux_backlight driver should check for the<br>
> DP_EDP_BACKLIGHT_BRIGHTNESS_<wbr>AUX_SET_CAP before enable the driver.<br>
><br>
> Signed-off-by: Puthikorn Voravootivat <<a href="mailto:puthik@chromium.org">puthik@chromium.org</a>><br>
> ---<br>
>  drivers/gpu/drm/i915/intel_dp_<wbr>aux_backlight.c | 5 ++---<br>
>  1 file changed, 2 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/i915/intel_<wbr>dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_<wbr>dp_aux_backlight.c<br>
> index 6532e226db29..24a905d1a74b 100644<br>
> --- a/drivers/gpu/drm/i915/intel_<wbr>dp_aux_backlight.c<br>
> +++ b/drivers/gpu/drm/i915/intel_<wbr>dp_aux_backlight.c<br>
> @@ -142,10 +142,9 @@ intel_dp_aux_display_control_<wbr>capable(struct intel_connector *connector)<br>
>       /* Check the  eDP Display control capabilities registers to determine if<br>
>        * the panel can support backlight control over the aux channel<br>
>        */<br>
> -     if (intel_dp->edp_dpcd[1] & DP_EDP_TCON_BACKLIGHT_<wbr>ADJUSTMENT_CAP &&<br>
> +     if ((intel_dp->edp_dpcd[1] & DP_EDP_TCON_BACKLIGHT_<wbr>ADJUSTMENT_CAP) &&<br>
>           (intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_<wbr>CAP) &&<br>
> -         !((intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_PIN_ENABLE_<wbr>CAP) ||<br>
> -           (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_<wbr>PWM_PIN_CAP))) {<br>
<br>
</span>^Were these two changes intended? The patch claims an additional check<br>
for DP_EDP_BACKLIGHT_BRIGHTNESS_<wbr>AUX_SET_CAP is being added but also<br>
makes this unrelated change. Aren't you changing how the driver<br>
prioritizes AUX v/s PWM brightness control by removing these lines?<br>
<br>
-DK<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> +         (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_<wbr>AUX_SET_CAP)) {<br>
>               DRM_DEBUG_KMS("AUX Backlight Control Supported!\n");<br>
>               return true;<br>
>       }<br>
<br>
</div></div></blockquote></div><br></div>