<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi,</div><div class="gmail_extra"><br><div class="gmail_quote">On 15 August 2017 at 22:14, Peter Griffin <span dir="ltr"><<a href="mailto:peter.griffin@linaro.org" target="_blank">peter.griffin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This patch fixes the following soft lockup:<br> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]<br> <br> On weston idle-timeout the IP is powered down and reset<br> asserted. On weston resume we get a massive vblank<br> IRQ storm due to the LDI registers having lost some state.<br> <br> This state loss is caused by ade_crtc_atomic_begin() not<br> calling ade_ldi_set_mode(). With this patch applied<br> resuming from Weston idle-timeout works well.<br> <br> Signed-off-by: Peter Griffin <<a href="mailto:peter.griffin@linaro.org" target="_blank">peter.griffin@linaro.org</a>><br> Tested-by: John Stultz <<a href="mailto:john.stultz@linaro.org" target="_blank">john.stultz@linaro.org</a>><br></blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks Peter,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">This patch looks good to me.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span class="m_3069310255583738913m_3063979403668195147gmail-il" style="font-family:arial,sans-serif;font-size:12.8px">Reviewed-by: Xinliang</span><span style="font-family:arial,sans-serif;font-size:12.8px"> Liu <</span><a href="mailto:xinliang.liu@linaro.org" style="font-family:arial,sans-serif;font-size:12.8px" target="_blank"><span class="m_3069310255583738913m_3063979403668195147gmail-il">xinliang</span>.liu@linaro.org</a><span style="font-family:arial,sans-serif;font-size:12.8px">></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">@Sean, could you please help to apply to drm-misc if others has no more comments, thanks.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Xinliang</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Cc: <a href="mailto:stable@vger.kernel.org" target="_blank">stable@vger.kernel.org</a><br> ---<br> drivers/gpu/drm/hisilicon/kir<wbr>in/kirin_drm_ade.c | 3 +++<br> 1 file changed, 3 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/hisilicon/ki<wbr>rin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/ki<wbr>rin/kirin_drm_ade.c<br> index c96c228..72c6357 100644<br> --- a/drivers/gpu/drm/hisilicon/ki<wbr>rin/kirin_drm_ade.c<br> +++ b/drivers/gpu/drm/hisilicon/ki<wbr>rin/kirin_drm_ade.c<br> @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,<br> {<br> struct ade_crtc *acrtc = to_ade_crtc(crtc);<br> struct ade_hw_ctx *ctx = acrtc->ctx;<br> + struct drm_display_mode *mode = &crtc->state->mode;<br> + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;<br> <br> if (!ctx->power_on)<br> (void)ade_power_up(ctx);<br> + ade_ldi_set_mode(acrtc, mode, adj_mode);<br> }<br> <br> static void ade_crtc_atomic_flush(struct drm_crtc *crtc,<br> <span class="m_3069310255583738913m_3063979403668195147gmail-HOEnZb"><font color="#888888">--<br> 2.7.4<br> <br> ______________________________<wbr>_________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.or<wbr>g</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/dri-devel</a><br> </font></span></blockquote></div><br></div></div>