<div dir="ltr">Acked-by: Mark Yao <<a href="mailto:mark.yao@rock-chips.com">mark.yao@rock-chips.com</a>></div><span>
</span><div><br></div><span>Thanks for the fix, and sorry for that, I'm in holidays now，currently has no environment to do the patch pushed.</span><div><br></div><div>I'll be back next week and do this patch push.</div><div><br></div><div>Thanks</div><div>Mark.<br><div class="gmail_quote"><div dir="ltr">On 2017年10月5日周四 19:10 Arnd Bergmann <<a href="mailto:arnd@arndb.de">arnd@arndb.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The new driver fails to build when CONFIG_PINCTRL is disabled:<br>
<br>
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config':<br>
drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct dev_pin_info'<br>
if (lvds->pins && !IS_ERR(lvds->pins->default_state))<br>
<br>
This adds the respective Kconfig dependency.<br>
<br>
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")<br>
Signed-off-by: Arnd Bergmann <<a href="mailto:arnd@arndb.de" target="_blank">arnd@arndb.de</a>><br>
---<br>
drivers/gpu/drm/rockchip/Kconfig | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig<br>
index 0c31f0a27b9c..3c70c6224bd2 100644<br>
--- a/drivers/gpu/drm/rockchip/Kconfig<br>
+++ b/drivers/gpu/drm/rockchip/Kconfig<br>
@@ -60,6 +60,7 @@ config ROCKCHIP_INNO_HDMI<br>
config ROCKCHIP_LVDS<br>
bool "Rockchip LVDS support"<br>
depends on DRM_ROCKCHIP<br>
+ depends on PINCTRL<br>
help<br>
Choose this option to enable support for Rockchip LVDS controllers.<br>
Rockchip rk3288 SoC has LVDS TX Controller can be used, and it<br>
--<br>
2.9.0<br>
<br>
<br>
<br>
<br>
</blockquote></div></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><pre class="inbox-inbox-inbox-inbox-inbox-moz-signature" cols="72">Ｍark Yao 姚智情
Rockchip 福州瑞芯微电子有限公司
Fuzhou Headquarters
Addr:No.21 Building, A District, Fuzhou
Software Park, 89 Soft Avenue, Tongpan Road,
Gulou District, Fuzhou (350003)
地址:福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003)
Tel:（86-0591）83991906 - 8296
<a class="inbox-inbox-inbox-inbox-inbox-moz-txt-link-abbreviated" href="mailto:E-mail:mark.yao@rock-chips.com">E-mail:mark.yao@rock-chips.com</a> </pre></div></div>