<html> <head> <meta http-equiv="content-type" content="text/html; charset=utf-8"> </head> <body bgcolor="#FFFFFF" text="#000000"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> Hi All,<o:p></o:p> <u1:p></u1:p> <u1:p> </u1:p><o:p></o:p> I am working for adding the DRM Client cap for the aspect ratio support as part of the series: <u1:p></u1:p><o:p></o:p> <a href="https://patchwork.freedesktop.org/series/10850/">https://patchwork.freedesktop.org/series/10850/</a> : Picture aspect ratio support in DRM layer by Shashank Sharma.<u1:p></u1:p><o:p></o:p> <u1:p> </u1:p><o:p></o:p> I have an open as to how to go about it.<u1:p></u1:p><o:p></o:p> <u1:p></u1:p><o:p></o:p> I was going through the existing DRM Client Cap like DRM_CLIENT_CAP_STEREO_3D, DRM_CLIENT_CAP_ATOMIC.<u1:p></u1:p><o:p></o:p> <u1:p></u1:p><o:p></o:p> On Similar lines, I was able to add the new DRM_CLIENT_CAP_ASPECT_RATIO. I also added a member 'aspect_ratio_required' in drm_file structure,<u1:p></u1:p><o:p></o:p> which is set, when the client calls drm_setclientcap( ), for aspect ratio, just like its being done for other DRM Client Caps. <u1:p></u1:p><o:p></o:p> <u1:p></u1:p><o:p></o:p> Now what I want to do is <u1:p></u1:p><o:p></o:p> 1. Setting the aspect-ratio flag-bits (19-22) in drmModeModeInfo only if the client advertises that it requires the aspect-ratio.<u1:p></u1:p><o:p></o:p> So I need to have this information (that client requires aspect ratio) available in the function:<u1:p></u1:p><o:p></o:p> drm_mode_convert_to_umode( ) : Where the flag bits are actually set<u1:p></u1:p><o:p></o:p> <u1:p> </u1:p><o:p></o:p> 2. Similarly in case of modeset request from the client, we would want to parse the aspect ratio bits from the requested drmModeModeInfo only if the client requires aspect ratio. <u1:p></u1:p><o:p></o:p> This will require change in the function:<u1:p></u1:p><o:p></o:p> drm_mode_convert_umode() : Where the flag bits of drm_mode_mode_info are read by the drm layer to determine the aspect ratio and set in drm_display_mode)<u1:p></u1:p><o:p></o:p> <u1:p></u1:p><o:p></o:p> The problem is that, both these functions have drm_mode_mode_info and drm_display_mode as the only arguments, but our flag aspect_ratio_required is in file_priv (struct drm_file).<u1:p></u1:p><o:p></o:p> <u1:p></u1:p><o:p></o:p> To do this there are two ways I can think of:<u1:p></u1:p><o:p></o:p> 1. Change the drm_mode_convert_umode() to include aspect_ratio_required flag.<o:p></o:p> Before calling this function, the file_priv->aspect_ratio_required will be checked and the flag will be set accordingly.<o:p></o:p> 2. While getting the drmClientCap from client, instead of storing this information in file-priv, store this info in some other structure.<u1:p></u1:p><o:p></o:p> <u1:p> </u1:p><o:p></o:p> Is my understanding correct or is there any other way I should handle the drm client cap?<o:p></o:p> <o:p> </o:p> Thanks and Regards,<o:p></o:p> Ankit  <o:p></o:p> <u1:p></u1:p> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="file:///C:%5CUsers%5CAKNAUTIY%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_filelist.xml">  <link rel="themeData" href="file:///C:%5CUsers%5CAKNAUTIY%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_themedata.thmx"> <link rel="colorSchemeMapping" href="file:///C:%5CUsers%5CAKNAUTIY%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_colorschememapping.xml">  <style>  </style> </body> </html>