<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Hello there, Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably up to date. I did a further check on github.com/torvalds/linux and the code looks wrong there, too. So I don't see the fix you mentioned in either of the places I looked. Regards David Binderman <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr">From: Jani Nikula <jani.nikula@linux.intel.com> Sent: 24 October 2017 08:54 To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] <div> </div> </div> </div> <div class="PlainText">On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote: > Hello there, > > Source code is > > if ((temp & PIPEACONF_PIPE_STATE) == 1) > break; > > but > > $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` > drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30) > $ > > Suggest new code > > if ((temp & PIPEACONF_PIPE_STATE) != 0) > break; Suggest looking at latest sources. ;) Fixed by 67a3b63a54cb ("drm: gma500: fix logic error"). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center </div> </div> </div> </body> </html>