<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body dir="auto">
<div></div>
<div>Drm-tip rebuild created this function duplication in some merge resolution... not sure where that came from or started... But Lucas had warned me yesterday morning...</div>
<div><br>
</div>
<div>So, yesterday night I added a fix-up on drm-rerere that remove the duplication on drm-tip... and that should be fixed by now I think...</div>
<div><br>
</div>
<div>Could you please fetch and recheck?!</div>
<div><br>
On Dec 30, 2017, at 9:10 AM, Wu, Fengguang <<a href="mailto:fengguang.wu@intel.com">fengguang.wu@intel.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div><span>tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip</span><br>
<span>head: 16432d39f2cbdc7a8798df3ebb4f7c882fb23132</span><br>
<span>commit: a79b622ef5cad1b3a868a1d7250494e39bb04c05 [1/7] Merge remote-tracking branch 'airlied/drm-next' into drm-tip</span><br>
<span>config: i386-randconfig-b0-12302345 (attached as .config)</span><br>
<span>compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4</span><br>
<span>reproduce:</span><br>
<span> git checkout a79b622ef5cad1b3a868a1d7250494e39bb04c05</span><br>
<span> # save the attached .config to linux build tree</span><br>
<span> make ARCH=i386 </span><br>
<span></span><br>
<span>Note: the drm-tip/drm-tip HEAD 16432d39f2cbdc7a8798df3ebb4f7c882fb23132 builds fine.</span><br>
<span> It only hurts bisectibility.</span><br>
<span></span><br>
<span>All errors (new ones prefixed by >>):</span><br>
<span></span><br>
<blockquote type="cite">
<blockquote type="cite"><span>drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:219:6: error: redefinition of 'dm_dp_mst_dc_sink_create'</span><br>
</blockquote>
</blockquote>
<span> void dm_dp_mst_dc_sink_create(struct drm_connector *connector)</span><br>
<span> ^</span><br>
<span> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:183:6: note: previous definition of 'dm_dp_mst_dc_sink_create' was here</span><br>
<span> void dm_dp_mst_dc_sink_create(struct drm_connector *connector)</span><br>
<span> ^</span><br>
<span></span><br>
<span>vim +/dm_dp_mst_dc_sink_create +219 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c</span><br>
<span></span><br>
<span>54427651 Jerry Zuo 2017-09-20 218 </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 @219) void dm_dp_mst_dc_sink_create(struct drm_connector *connector)</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 220) {</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 221) struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 222) struct edid *edid;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 223) struct dc_sink *dc_sink;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 224) struct dc_sink_init_data init_params = {</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 225) .link = aconnector->dc_link,</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 226) .sink_signal = SIGNAL_TYPE_DISPLAY_PORT_MST };</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 227) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 228) edid = drm_dp_mst_get_edid(connector, &aconnector->mst_port->mst_mgr, aconnector->port);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 229) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 230) if (!edid) {</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 231) drm_mode_connector_update_edid_property(</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 232) &aconnector->base,</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 233) NULL);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 234) return;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 235) }</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 236) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 237) aconnector->edid = edid;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 238) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 239) dc_sink = dc_link_add_remote_sink(</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 240) aconnector->dc_link,</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 241) (uint8_t *)aconnector->edid,</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 242) (aconnector->edid->extensions + 1) * EDID_LENGTH,</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 243) &init_params);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 244) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 245) dc_sink->priv = aconnector;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 246) aconnector->dc_sink = dc_sink;</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 247) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 248) amdgpu_dm_add_sink_to_freesync_module(</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 249) connector, aconnector->edid);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 250) </span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 251) drm_mode_connector_update_edid_property(</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 252) &aconnector->base, aconnector->edid);</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 253) }</span><br>
<span>becd0875 Jerry (Fangzhi Zuo 2017-12-01 254) </span><br>
<span></span><br>
<span>:::::: The code at line 219 was first introduced by commit</span><br>
<span>:::::: becd0875f4393a992afbf57aa323f7bf1a71c3ff drm/amd/display: Fix rehook MST display not light back on</span><br>
<span></span><br>
<span>:::::: TO: Jerry (Fangzhi) Zuo <<a href="mailto:Jerry.Zuo@amd.com">Jerry.Zuo@amd.com</a>></span><br>
<span>:::::: CC: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>></span><br>
<span></span><br>
<span>---</span><br>
<span>0-DAY kernel test infrastructure Open Source Technology Center</span><br>
<span><a href="https://lists.01.org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation</span><br>
</div>
</blockquote>
<blockquote type="cite">
<div><.config.gz></div>
</blockquote>
</body>
</html>