<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gbk">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">ÔÚ 2018/4/17 19:14, Heiko Stuebner дµÀ:<br>
</div>
<blockquote type="cite" cite="mid:2475172.s4GHAT5PDW@phil">
<pre wrap="">Hi Sandy,
Am Dienstag, 17. April 2018, 12:15:07 CEST schrieb Sandy Huang:
</pre>
<blockquote type="cite">
<pre wrap="">When video width is bigger than 3840 the linebuffer mode
should be LB_YUV_3840X5.
</pre>
</blockquote>
<pre wrap="">
Can you explain that a bit better?
I.e. when looking at the code, the very first check is width > 2560.
So it seems your change targets some YUV mode with width > 3840
which should be mentioned in the commit message, so people like
me don't scratch their head in confusion ;-)
Similarly that check is actually width > 1280 to set LB_YUV_3840X5,
so I guess you're actually wanting any YUV mode bigger than
1280px should use LB_YUV_3840X5?
Heiko</pre>
</blockquote>
Thanks heiko,<br>
I will make more description for this path at next version.<br>
<span style="color: rgb(67, 67, 67); font-family: Tahoma, Arial, ËÎÌå,
'Malgun Gothic'; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing: normal;
line-height: 24px; orphans: auto; text-align: justify;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgba(255, 255, 255, 0.8); display: inline
!important; float: none;"></span>
<blockquote type="cite" cite="mid:2475172.s4GHAT5PDW@phil">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Signed-off-by: Sandy Huang <a class="moz-txt-link-rfc2396E" href="mailto:hjc@rock-chips.com"><hjc@rock-chips.com></a>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
index 56bbd2e..3e7501b 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
@@ -332,7 +332,7 @@ static inline int scl_vop_cal_lb_mode(int width, bool is_yuv)
if (width > 2560)
lb_mode = LB_RGB_3840X2;
- else if (width > 1920)
+ else if (!is_yuv && width > 1920)
lb_mode = LB_RGB_2560X4;
else if (!is_yuv)
lb_mode = LB_RGB_1920X5;
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>