<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Thanks Julia.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">It's a typo. And a patch had been sent out to fix it.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Regards,</p>
<p style="margin-top:0;margin-bottom:0">Evan</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Julia Lawall <julia.lawall@lip6.fr><br>
<b>Sent:</b> Saturday, May 19, 2018 4:50:04 AM<br>
<b>To:</b> Quan, Evan<br>
<b>Cc:</b> Deucher, Alexander; dri-devel@lists.freedesktop.org; kbuild-all@01.org; Koenig, Christian; Huang, Ray<br>
<b>Subject:</b> [radeon-alex:drm-next-4.18-wip 44/78] drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or | (fwd)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Lines 680 and 682 contain the same constant.<br>
<br>
julia<br>
<br>
---------- Forwarded message ----------<br>
Date: Sat, 19 May 2018 04:22:09 +0800<br>
From: kbuild test robot <lkp@intel.com><br>
To: kbuild@01.org<br>
Cc: Julia Lawall <julia.lawall@lip6.fr><br>
Subject: [radeon-alex:drm-next-4.18-wip 44/78]<br>
drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or |<br>
<br>
CC: kbuild-all@01.org<br>
CC: dri-devel@lists.freedesktop.org<br>
TO: Evan Quan <evan.quan@amd.com><br>
CC: Alex Deucher <alexander.deucher@amd.com><br>
CC: "Christian König" <christian.koenig@amd.com><br>
CC: Huang Rui <ray.huang@amd.com><br>
<br>
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip<br>
head: aa1bce17d841a362d40da940487e13affe4c7b3b<br>
commit: 27eab5ad57b2da7803bb3e5d61c666b52b57d6f6 [44/78] drm/amd/powerplay: update vega20 cg flags<br>
:::::: branch date: 26 hours ago<br>
:::::: commit date: 29 hours ago<br>
<br>
>> drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or |<br>
<br>
git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git<br>
git remote update radeon-alex<br>
git checkout 27eab5ad57b2da7803bb3e5d61c666b52b57d6f6<br>
vim +680 drivers/gpu/drm/amd/amdgpu/soc15.c<br>
<br>
220ab9bd1 Ken Wang 2017-03-06 599<br>
220ab9bd1 Ken Wang 2017-03-06 600 static int soc15_common_early_init(void *handle)<br>
220ab9bd1 Ken Wang 2017-03-06 601 {<br>
220ab9bd1 Ken Wang 2017-03-06 602 struct amdgpu_device *adev = (struct amdgpu_device *)handle;<br>
220ab9bd1 Ken Wang 2017-03-06 603<br>
220ab9bd1 Ken Wang 2017-03-06 604 adev->smc_rreg = NULL;<br>
220ab9bd1 Ken Wang 2017-03-06 605 adev->smc_wreg = NULL;<br>
220ab9bd1 Ken Wang 2017-03-06 606 adev->pcie_rreg = &soc15_pcie_rreg;<br>
220ab9bd1 Ken Wang 2017-03-06 607 adev->pcie_wreg = &soc15_pcie_wreg;<br>
220ab9bd1 Ken Wang 2017-03-06 608 adev->uvd_ctx_rreg = &soc15_uvd_ctx_rreg;<br>
220ab9bd1 Ken Wang 2017-03-06 609 adev->uvd_ctx_wreg = &soc15_uvd_ctx_wreg;<br>
220ab9bd1 Ken Wang 2017-03-06 610 adev->didt_rreg = &soc15_didt_rreg;<br>
220ab9bd1 Ken Wang 2017-03-06 611 adev->didt_wreg = &soc15_didt_wreg;<br>
560460f28 Evan Quan 2017-07-03 612 adev->gc_cac_rreg = &soc15_gc_cac_rreg;<br>
560460f28 Evan Quan 2017-07-03 613 adev->gc_cac_wreg = &soc15_gc_cac_wreg;<br>
2f11fb028 Evan Quan 2017-07-04 614 adev->se_cac_rreg = &soc15_se_cac_rreg;<br>
2f11fb028 Evan Quan 2017-07-04 615 adev->se_cac_wreg = &soc15_se_cac_wreg;<br>
220ab9bd1 Ken Wang 2017-03-06 616<br>
220ab9bd1 Ken Wang 2017-03-06 617 adev->asic_funcs = &soc15_asic_funcs;<br>
220ab9bd1 Ken Wang 2017-03-06 618<br>
220ab9bd1 Ken Wang 2017-03-06 619 adev->rev_id = soc15_get_rev_id(adev);<br>
220ab9bd1 Ken Wang 2017-03-06 620 adev->external_rev_id = 0xFF;<br>
220ab9bd1 Ken Wang 2017-03-06 621 switch (adev->asic_type) {<br>
220ab9bd1 Ken Wang 2017-03-06 622 case CHIP_VEGA10:<br>
220ab9bd1 Ken Wang 2017-03-06 623 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 624 AMD_CG_SUPPORT_GFX_MGLS |<br>
220ab9bd1 Ken Wang 2017-03-06 625 AMD_CG_SUPPORT_GFX_RLC_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 626 AMD_CG_SUPPORT_GFX_CP_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 627 AMD_CG_SUPPORT_GFX_3D_CGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 628 AMD_CG_SUPPORT_GFX_3D_CGLS |<br>
220ab9bd1 Ken Wang 2017-03-06 629 AMD_CG_SUPPORT_GFX_CGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 630 AMD_CG_SUPPORT_GFX_CGLS |<br>
220ab9bd1 Ken Wang 2017-03-06 631 AMD_CG_SUPPORT_BIF_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 632 AMD_CG_SUPPORT_BIF_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 633 AMD_CG_SUPPORT_HDP_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 634 AMD_CG_SUPPORT_DRM_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 635 AMD_CG_SUPPORT_DRM_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 636 AMD_CG_SUPPORT_ROM_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 637 AMD_CG_SUPPORT_DF_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 638 AMD_CG_SUPPORT_SDMA_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 639 AMD_CG_SUPPORT_SDMA_LS |<br>
220ab9bd1 Ken Wang 2017-03-06 640 AMD_CG_SUPPORT_MC_MGCG |<br>
220ab9bd1 Ken Wang 2017-03-06 641 AMD_CG_SUPPORT_MC_LS;<br>
220ab9bd1 Ken Wang 2017-03-06 642 adev->pg_flags = 0;<br>
220ab9bd1 Ken Wang 2017-03-06 643 adev->external_rev_id = 0x1;<br>
220ab9bd1 Ken Wang 2017-03-06 644 break;<br>
692069a1a Alex Deucher 2018-03-06 645 case CHIP_VEGA12:<br>
e4a387558 Evan Quan 2017-12-25 646 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 647 AMD_CG_SUPPORT_GFX_MGLS |<br>
e4a387558 Evan Quan 2017-12-25 648 AMD_CG_SUPPORT_GFX_CGCG |<br>
e4a387558 Evan Quan 2017-12-25 649 AMD_CG_SUPPORT_GFX_CGLS |<br>
e4a387558 Evan Quan 2017-12-25 650 AMD_CG_SUPPORT_GFX_3D_CGCG |<br>
e4a387558 Evan Quan 2017-12-25 651 AMD_CG_SUPPORT_GFX_3D_CGLS |<br>
e4a387558 Evan Quan 2017-12-25 652 AMD_CG_SUPPORT_GFX_CP_LS |<br>
e4a387558 Evan Quan 2017-12-25 653 AMD_CG_SUPPORT_MC_LS |<br>
e4a387558 Evan Quan 2017-12-25 654 AMD_CG_SUPPORT_MC_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 655 AMD_CG_SUPPORT_SDMA_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 656 AMD_CG_SUPPORT_SDMA_LS |<br>
e4a387558 Evan Quan 2017-12-25 657 AMD_CG_SUPPORT_BIF_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 658 AMD_CG_SUPPORT_BIF_LS |<br>
e4a387558 Evan Quan 2017-12-25 659 AMD_CG_SUPPORT_HDP_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 660 AMD_CG_SUPPORT_HDP_LS |<br>
e4a387558 Evan Quan 2017-12-25 661 AMD_CG_SUPPORT_ROM_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 662 AMD_CG_SUPPORT_VCE_MGCG |<br>
e4a387558 Evan Quan 2017-12-25 663 AMD_CG_SUPPORT_UVD_MGCG;<br>
692069a1a Alex Deucher 2018-03-06 664 adev->pg_flags = 0;<br>
f559fe2bc Feifei Xu 2017-12-14 665 adev->external_rev_id = adev->rev_id + 0x14;<br>
692069a1a Alex Deucher 2018-03-06 666 break;<br>
935be7a0c Feifei Xu 2018-01-26 667 case CHIP_VEGA20:<br>
27eab5ad5 Evan Quan 2018-03-26 668 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 669 AMD_CG_SUPPORT_GFX_MGLS |<br>
27eab5ad5 Evan Quan 2018-03-26 670 AMD_CG_SUPPORT_GFX_CGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 671 AMD_CG_SUPPORT_GFX_CGLS |<br>
27eab5ad5 Evan Quan 2018-03-26 672 AMD_CG_SUPPORT_GFX_3D_CGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 673 AMD_CG_SUPPORT_GFX_3D_CGLS |<br>
27eab5ad5 Evan Quan 2018-03-26 674 AMD_CG_SUPPORT_GFX_CP_LS |<br>
27eab5ad5 Evan Quan 2018-03-26 675 AMD_CG_SUPPORT_MC_LS |<br>
27eab5ad5 Evan Quan 2018-03-26 676 AMD_CG_SUPPORT_MC_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 677 AMD_CG_SUPPORT_SDMA_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 678 AMD_CG_SUPPORT_SDMA_LS |<br>
27eab5ad5 Evan Quan 2018-03-26 679 AMD_CG_SUPPORT_BIF_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 @680 AMD_CG_SUPPORT_BIF_LS |<br>
27eab5ad5 Evan Quan 2018-03-26 681 AMD_CG_SUPPORT_HDP_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 682 AMD_CG_SUPPORT_BIF_LS |<br>
27eab5ad5 Evan Quan 2018-03-26 683 AMD_CG_SUPPORT_ROM_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 684 AMD_CG_SUPPORT_VCE_MGCG |<br>
27eab5ad5 Evan Quan 2018-03-26 685 AMD_CG_SUPPORT_UVD_MGCG;<br>
935be7a0c Feifei Xu 2018-01-26 686 adev->pg_flags = 0;<br>
935be7a0c Feifei Xu 2018-01-26 687 adev->external_rev_id = adev->rev_id + 0x28;<br>
935be7a0c Feifei Xu 2018-01-26 688 break;<br>
957c6fe18 Hawking Zhang 2016-12-27 689 case CHIP_RAVEN:<br>
5c5928a23 Huang Rui 2017-01-18 690 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |<br>
5c5928a23 Huang Rui 2017-01-18 691 AMD_CG_SUPPORT_GFX_MGLS |<br>
5c5928a23 Huang Rui 2017-01-18 692 AMD_CG_SUPPORT_GFX_RLC_LS |<br>
5c5928a23 Huang Rui 2017-01-18 693 AMD_CG_SUPPORT_GFX_CP_LS |<br>
5c5928a23 Huang Rui 2017-01-18 694 AMD_CG_SUPPORT_GFX_3D_CGCG |<br>
5c5928a23 Huang Rui 2017-01-18 695 AMD_CG_SUPPORT_GFX_3D_CGLS |<br>
5c5928a23 Huang Rui 2017-01-18 696 AMD_CG_SUPPORT_GFX_CGCG |<br>
5c5928a23 Huang Rui 2017-01-18 697 AMD_CG_SUPPORT_GFX_CGLS |<br>
5c5928a23 Huang Rui 2017-01-18 698 AMD_CG_SUPPORT_BIF_MGCG |<br>
5c5928a23 Huang Rui 2017-01-18 699 AMD_CG_SUPPORT_BIF_LS |<br>
5c5928a23 Huang Rui 2017-01-18 700 AMD_CG_SUPPORT_HDP_MGCG |<br>
5c5928a23 Huang Rui 2017-01-18 701 AMD_CG_SUPPORT_HDP_LS |<br>
5c5928a23 Huang Rui 2017-01-18 702 AMD_CG_SUPPORT_DRM_MGCG |<br>
5c5928a23 Huang Rui 2017-01-18 703 AMD_CG_SUPPORT_DRM_LS |<br>
c2cdb0ec0 Huang Rui 2017-05-05 704 AMD_CG_SUPPORT_ROM_MGCG |<br>
c2cdb0ec0 Huang Rui 2017-05-05 705 AMD_CG_SUPPORT_MC_MGCG |<br>
fe1a3b2e4 Huang Rui 2017-05-05 706 AMD_CG_SUPPORT_MC_LS |<br>
fe1a3b2e4 Huang Rui 2017-05-05 707 AMD_CG_SUPPORT_SDMA_MGCG |<br>
fe1a3b2e4 Huang Rui 2017-05-05 708 AMD_CG_SUPPORT_SDMA_LS;<br>
400b6afba Huang Rui 2017-12-14 709 adev->pg_flags = AMD_PG_SUPPORT_SDMA;<br>
400b6afba Huang Rui 2017-12-14 710<br>
9ac4b0d95 Huang Rui 2017-12-15 711 if (adev->powerplay.pp_feature & PP_GFXOFF_MASK)<br>
9ac4b0d95 Huang Rui 2017-12-15 712 adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br>
9ac4b0d95 Huang Rui 2017-12-15 713 AMD_PG_SUPPORT_CP |<br>
9ac4b0d95 Huang Rui 2017-12-15 714 AMD_PG_SUPPORT_RLC_SMU_HS;<br>
9ac4b0d95 Huang Rui 2017-12-15 715<br>
957c6fe18 Hawking Zhang 2016-12-27 716 adev->external_rev_id = 0x1;<br>
957c6fe18 Hawking Zhang 2016-12-27 717 break;<br>
220ab9bd1 Ken Wang 2017-03-06 718 default:<br>
220ab9bd1 Ken Wang 2017-03-06 719 /* FIXME: not supported yet */<br>
220ab9bd1 Ken Wang 2017-03-06 720 return -EINVAL;<br>
220ab9bd1 Ken Wang 2017-03-06 721 }<br>
220ab9bd1 Ken Wang 2017-03-06 722<br>
ab276632e Xiangliang Yu 2017-04-21 723 if (amdgpu_sriov_vf(adev)) {<br>
ab276632e Xiangliang Yu 2017-04-21 724 amdgpu_virt_init_setting(adev);<br>
ab276632e Xiangliang Yu 2017-04-21 725 xgpu_ai_mailbox_set_irq_funcs(adev);<br>
ab276632e Xiangliang Yu 2017-04-21 726 }<br>
ab276632e Xiangliang Yu 2017-04-21 727<br>
220ab9bd1 Ken Wang 2017-03-06 728 return 0;<br>
220ab9bd1 Ken Wang 2017-03-06 729 }<br>
220ab9bd1 Ken Wang 2017-03-06 730<br>
<br>
---<br>
0-DAY kernel test infrastructure Open Source Technology Center<br>
<a href="https://lists.01.org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation</div>
</span></font></div>
</body>
</html>