<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 14, 2018 at 7:52 PM, Keith Packard <span dir="ltr"><<a href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This extension is required to support EXT_display_control as it offers<br>
a way to query whether the vblank counter is supported.<br>
<br>
v2: Thanks to kisak<br>
<br>
Fix spelling of VkSurfaceCapabilities2EXT in wsi_common_wayland.c,<br>
it was using ext instead of EXT.<br>
<br>
Fix spelling of VK_STRUCTURE_TYPE_SURFACE_<wbr>CAPABILITIES_2_EXT<br>
<br>
v3: Fix wayland WSI, regularize spelling<br>
<br>
Misspelled 'surface' in get_capabilities2ext<br>
Remove extra _ from get_capabilities_2ext in a couple of places<br>
<br>
v4: Adopt Jason Ekstrand's coding conventions<br>
<br>
Declare variables at first use, eliminate extra whitespace<br>
between types and names. Wrap lines to 80 columns.<br>
<br>
Suggested-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
<br>
Signed-off-by: Keith Packard <<a href="mailto:keithp@keithp.com">keithp@keithp.com</a>><br>
---<br>
src/vulkan/wsi/wsi_common.c | 12 ++++++++++++<br>
src/vulkan/wsi/wsi_common.h | 6 ++++++<br>
src/vulkan/wsi/wsi_common_<wbr>display.c | 27 +++++++++++++++++++++++++++<br>
src/vulkan/wsi/wsi_common_<wbr>private.h | 3 +++<br>
src/vulkan/wsi/wsi_common_<wbr>wayland.c | 27 +++++++++++++++++++++++++++<br>
src/vulkan/wsi/wsi_common_x11.<wbr>c | 27 +++++++++++++++++++++++++++<br>
6 files changed, 102 insertions(+)<br>
<br>
diff --git a/src/vulkan/wsi/wsi_common_<wbr>private.h b/src/vulkan/wsi/wsi_common_<wbr>private.h<br>
index 3d502b9fc9d..b97d2d8ba06 100644<br>
--- a/src/vulkan/wsi/wsi_common_<wbr>private.h<br>
+++ b/src/vulkan/wsi/wsi_common_<wbr>private.h<br>
@@ -109,6 +109,9 @@ struct wsi_interface {<br>
VkResult (*get_capabilities2)(<wbr>VkIcdSurfaceBase *surface,<br>
const void *info_next,<br>
VkSurfaceCapabilities2KHR* pSurfaceCapabilities);<br>
+ VkResult (*get_capabilities2ext)(<wbr>VkIcdSurfaceBase *surface,<br>
+ VkSurfaceCapabilities2EXT*<br>
+ pSurfaceCapabilities);<br></blockquote><div><br></div><div>I really don't like adding a third get_capabilities hook. An alternative way to do this would be to add a pseud-extension which allows you do get he extra bit of data with a chain-in on vkGetSurfaceCapabilities2KHR. I sent two patches which do just that. If you like them, I'm happy do do the reabase for you if you'd like.</div><div><br></div><div>--Jason<br></div></div><br></div></div>