<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jun 19, 2018 at 1:56 PM, Keith Packard <span dir="ltr"><<a href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> writes:<br>
<br>
> 1) We weren't setting planeReorderPossible at all and we were using 0<br>
> instead of VK_FALSE (they're the same but we should use the enum) for<br>
> persistentContent<br>
> 2) We weren't advertising disconnected connectors via<br>
> GetPhysicalDeviceDisplayProper<wbr>ties but were returning them from<br>
> GetPhysicalDeviceDisplayPlaneP<wbr>roperties.<br>
> 3) We weren't setting result if the condition variable failed to<br>
> initialize (thanks GCC!)<br>
> <br>
> There is one outstanding issue that the CTS is complaining about, namely<br>
> that you can't create modes. It tests that mode creation fails for a mode<br>
> with a zero width, height, or refresh rate and that's all fine. It then<br>
> tries to re-create one of the modes that we've returned to it in<br>
> GetDisplayModeProperties and assumes that it will work. We should probably<br>
> at least make sure that works by walking the list and looking for a mode<br>
> that matches the requested one and returning it. I don't think anything<br>
> actually requires us to return a unique pointer so it can be a search<br>
> instead of a create.<br>
<br>
</span>And that seems to at least make CTS happy. I've merged your fixes into<br>
the first patch, added support for vkCreateDisplayModeKHR, rebased to<br>
master and pushed the results to my repository.<br>
<br>
It looks like we're done here but I'll wait until I hear from you before<br>
pushing to master in case you've got additional concerns.<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>Looks good. Passes the CTS. Push it! <br></div></div><br></div></div>