<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107012#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107012">bug 107012</a>
from <span class="vcard"><a class="email" href="mailto:smcv@collabora.com" title="Simon McVittie <smcv@collabora.com>"> <span class="fn">Simon McVittie</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=140294" name="attach_140294" title="Fix crashes">attachment 140294</a> <a href="attachment.cgi?id=140294&action=edit" title="Fix crashes">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=107012&attachment=140294'>[review]</a>
Fix crashes
Review of <span class=""><a href="attachment.cgi?id=140294" name="attach_140294" title="Fix crashes">attachment 140294</a> <a href="attachment.cgi?id=140294&action=edit" title="Fix crashes">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=107012&attachment=140294'>[review]</a>:
-----------------------------------------------------------------
::: src/gallium/drivers/radeonsi/si_shader.h
@@ +507,4 @@
<span class="quote">> unsigned ancillary_vgpr_index:5;
> unsigned wqm:1;
> char color_attr_index[2];
> + signed color_interp_vgpr_index[2]; /* -1 == constant */</span >
Shouldn't this be a signed char, to make the size of the struct the same on all
architectures?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>