<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - When starting a match Rocket League crashes on "Go"" href="https://bugs.freedesktop.org/show_bug.cgi?id=106928#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - When starting a match Rocket League crashes on "Go"" href="https://bugs.freedesktop.org/show_bug.cgi?id=106928">bug 106928</a> from <a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> Roland Scheidegger</a> <pre>(In reply to Dave Airlie from <a href="show_bug.cgi?id=106928#c14">comment #14</a>) > I think Roland's first patch is correct, just call fold_alu_op2 if we get > back 2 sources from fold_assoc. return true is for when we've finished all > folding on that instruction, so I don't think that's correct without calling > fold_alu_op2 Well it would still be called (in fold_assoc instead) in this case so the only difference in the end really is that fold_alu_op3 would return false instead of true if fold_alu_op2 (called when fold_assoc reduced number of src to 2) returned false. If the return value is just indicating if we're finished with folding, then I suppose it does not actually matter for correctness either way This code was all written by Vadim Girlin, but I don't think he's still around here.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>