<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - When starting a match Rocket League crashes on "Go"" href="https://bugs.freedesktop.org/show_bug.cgi?id=106928#c17">Comment # 17</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - When starting a match Rocket League crashes on "Go"" href="https://bugs.freedesktop.org/show_bug.cgi?id=106928">bug 106928</a> from <a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> Roland Scheidegger</a> <pre>(In reply to ubizjak from <a href="show_bug.cgi?id=106928#c15">comment #15</a>) > (In reply to Dave Airlie from <a href="show_bug.cgi?id=106928#c14">comment #14</a>) > > I think Roland's first patch is correct, just call fold_alu_op2 if we get > > back 2 sources from fold_assoc. return true is for when we've finished all > > folding on that instruction, so I don't think that's correct without calling > > fold_alu_op2 > > LGTM then (it also fixes the failure for me), but can we please drop the > "else" from the patch, it is really confusing. Sure that can be done. (I was actually also wondering if the test for n.src.size() < 3 at the beginning of the function is actually necessary, are we really supposed to have already fewer sources when this is called? But I couldn't quite answer that. This code is a bit confusing to me.)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>