<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Make darktable OpenCL support work on Clover and RadeonSI"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=107115">107115</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Make darktable OpenCL support work on Clover and RadeonSI
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>git
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>x86-64 (AMD64)
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>FreeBSD
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Drivers/Gallium/radeonsi
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>dri-devel@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>greg@unrelenting.technology
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>dri-devel@lists.freedesktop.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Hi everyone, I've tried to get the darktable photo editor
<a href="https://www.darktable.org">https://www.darktable.org</a> to work, and there's more to it than image support...

First, I've picked up funfunctor's patches (mentioned in <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Tracker bug for runnning OpenCL applications on Clover"
   href="show_bug.cgi?id=99553">bug 99553</a>), they
applied cleanly to master (except for the little one-line "= 1" since the
r600/radeonsi split happened, but that was trivial to fix). My branch with them
is <a href="https://github.com/myfreeweb/mesa/tree/clover-image">https://github.com/myfreeweb/mesa/tree/clover-image</a>

Second, there was some weird mismatch between libclc's headers and darktable's
code, and I've had to do:

%s/write_only image2d_t/image2d_t

and

%s/__image2d_t/image2d_t

on all files in PREFIX/share/darktable/kernels.

Third, the liquify.cl kernel triggered the
<a href="https://bugs.llvm.org/show_bug.cgi?id=36679">https://bugs.llvm.org/show_bug.cgi?id=36679</a> crash (which is fixed in llvm 7...
but I just removed the function body to proceed without this particular effect)

And finally, with all kernels compiled, darktable benchmarked CPU vs GPU and
found the CPU to be a bit faster (yay for Ryzen) and disabled OpenCL usage.

Enabling OpenCL usage in the settings and then double clicking on an image...
uhh... hard locked the GPU :D

drmn0: GPU fault detected: 147 0x05004402
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR   0x005000A0
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x08044002
drmn0: VM fault (0x02, vmid 4) at page 5243040, read from 'TC5' (0x54433500)
(68)

P.S. system info: AMD Radeon RX 480, FreeBSD 12-CURRENT / drm-next-kmod 4.15
(DRM 3.23.0) with amdgpu.dc=1, LLVM 6.0.0, Mesa with patches on top of git rev
c2ae9b4052701, libclc git rev c45b9dfe5257, darktable 2.4.4.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>