<div dir="ltr"><div><div>I forgot about this since we started discussing possible scenarios of processes and threads.<br><br></div>In any case, this check is redundant. Acked-by: Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com">nayan26deshmukh@gmail.com</a>><br><br></div>Nayan<br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 6, 2018 at 7:43 PM Christian König <<a href="mailto:ckoenig.leichtzumerken@gmail.com">ckoenig.leichtzumerken@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping. Any objections to that?<br>
<br>
Christian.<br>
<br>
Am 03.08.2018 um 13:08 schrieb Christian König:<br>
> That is superflous now.<br>
><br>
> Signed-off-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br>
> ---<br>
>   drivers/gpu/drm/scheduler/gpu_scheduler.c | 5 -----<br>
>   1 file changed, 5 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c<br>
> index 85908c7f913e..65078dd3c82c 100644<br>
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c<br>
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c<br>
> @@ -590,11 +590,6 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,<br>
>       if (first) {<br>
>               /* Add the entity to the run queue */<br>
>               spin_lock(&entity->rq_lock);<br>
> -             if (!entity->rq) {<br>
> -                     DRM_ERROR("Trying to push to a killed entity\n");<br>
> -                     spin_unlock(&entity->rq_lock);<br>
> -                     return;<br>
> -             }<br>
>               drm_sched_rq_add_entity(entity->rq, entity);<br>
>               spin_unlock(&entity->rq_lock);<br>
>               drm_sched_wakeup(entity->rq->sched);<br>
<br>
</blockquote></div>