<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:isaaccurtis1@gmail.com" title="Isaac Curtis <isaaccurtis1@gmail.com>"> <span class="fn">Isaac Curtis</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED NOTOURBUG - Flickering artifacts in OpenRA with Vega 56"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107428">bug 107428</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>NOTOURBUG
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED NOTOURBUG - Flickering artifacts in OpenRA with Vega 56"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107428#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED NOTOURBUG - Flickering artifacts in OpenRA with Vega 56"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107428">bug 107428</a>
from <span class="vcard"><a class="email" href="mailto:isaaccurtis1@gmail.com" title="Isaac Curtis <isaaccurtis1@gmail.com>"> <span class="fn">Isaac Curtis</span></a>
</span></b>
<pre>The bug has been identified. It can be seen on Lines 40-53 of
<a href="https://github.com/OpenRA/OpenRA/blob/bfcbe8c0043bfadd1b38c4987f133e29aa54275c/glsl/shp.frag">https://github.com/OpenRA/OpenRA/blob/bfcbe8c0043bfadd1b38c4987f133e29aa54275c/glsl/shp.frag</a>
Basically, it was a floating point comparison bug. It checked for samplerIndex
a float that takes int values, against 1.0, 2.0, etc. However, sometimes 1 is
less than 1 due to floating point issues. Changing samplerIndex < 1.0 to
samplerIndex < 0.5 fixes the issue.
It turns out that AMDGPU drivers seem to be the only implementation that
experience this particular issue.
This case is resolved. I don't see anything to fix in the drivers here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>