<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106175#c58">Comment # 58</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106175">bug 106175</a>
from <span class="vcard"><a class="email" href="mailto:nicholas.kazlauskas@amd.com" title="Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>"> <span class="fn">Nicholas Kazlauskas</span></a>
</span></b>
<pre>(In reply to Brandon Wright from <a href="show_bug.cgi?id=106175#c55">comment #55</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=142558" name="attach_142558" title="Patch that "fixes" the problem.">attachment 142558</a> <a href="attachment.cgi?id=142558&action=edit" title="Patch that "fixes" the problem.">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=106175&attachment=142558'>[review]</a> [review]
> Patch that "fixes" the problem.
>
> I've attached a patch that fixes the problem for me. It copies parts from
> the intel patch and uses the existing async infrastructure for the cursor.
>
> It's really tiny, so I hope this is helpful enough to get this problem fixed
> quick.</span >
This is a nice attempt but it only resolves the problem because it relies on
the blocking behavior in atomic check that amdgpu_dm currently does (and
shouldn't be doing).
Asynchronous updates can and will occur in parallel with other commits on
worker threads. Without the wait in atomic_check you'll see the IGT legacy
cursor tests break with this patch (and there will probably be system faults as
well).
There are larger problems within amdgpu_dm's commit tail that if addressed
should resolve this issue for compton I'd imagine.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>