<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - "xf86drm: Add drmIsMaster()" commit breaks X server builds"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109587">109587</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>"xf86drm: Add drmIsMaster()" commit breaks X server builds
</td>
</tr>
<tr>
<th>Product</th>
<td>DRI
</td>
</tr>
<tr>
<th>Version</th>
<td>XOrg git
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>major
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>libdrm
</td>
</tr>
<tr>
<th>Assignee</th>
<td>dri-devel@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>eero.t.tamminen@intel.com
</td>
</tr></table>
<p>
<div>
<pre>Following commit:
-----------------------------------------------
commit 17dfe3ac93217b43f93bc81d1129bd38a89d0368
Author: Christopher James Halse Rogers
<<a href="mailto:christopher.halse.rogers@canonical.com">christopher.halse.rogers@canonical.com</a>>
AuthorDate: Wed Jan 23 15:38:45 2019 +1100
Commit: Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>>
CommitDate: Thu Feb 7 17:43:01 2019 +0000
xf86drm: Add drmIsMaster()
...
--- a/xf86drm.h
+++ b/xf86drm.h
@@ -37,6 +37,7 @@
#include <stdarg.h>
#include <sys/types.h>
#include <stdint.h>
+#include <stdbool.h>
-----------------------------------------------
Breaks X server build:
-----------------------------------------------
FAILED: hw/xfree86/dri2/xorg_dri2@sta/dri2.c.o
...
In file included from /path/to/include/xf86drm.h:40:0,
from /path/to/hw/xfree86/dri2/dri2.c:39:
/path/to/hw/xfree86/common/xf86Opt.h:44:10: error: two or more data types in
declaration specifiers
Bool bool;
^
In file included from /path/to/hw/xfree86/common/xf86str.h:43:0,
from /path/to/hw/xfree86/common/xf86.h:44,
from /path/to/hw/xfree86/dri2/dri2.c:48:
/path/to/hw/xfree86/common/xf86Opt.h:44:14: warning: declaration does not
declare anything
Bool bool;
^
-----------------------------------------------
Because couple of structures in X source code are using struct members named as
"bool" (added in 2012):
./hw/xfree86/common/xf86Opt.h: Bool bool;
./hw/xwin/winconfig.h: Bool bool;
(FYI: Bool is defined as "int" in several X headers.)
Please revert the part adding "stdbool.h" include / "bool" typedef to the
xf86drm.h header used by X server, until somebody renames those badly named
struct members in X server sources.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>