<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:fdo-bugs@engestrom.ch" title="Eric Engestrom <fdo-bugs@engestrom.ch>"> <span class="fn">Eric Engestrom</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Segmentation fault in drmParsePlatformDeviceInfo"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109977">bug 109977</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>emil.l.velikov@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Segmentation fault in drmParsePlatformDeviceInfo"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109977#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Segmentation fault in drmParsePlatformDeviceInfo"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109977">bug 109977</a>
from <span class="vcard"><a class="email" href="mailto:fdo-bugs@engestrom.ch" title="Eric Engestrom <fdo-bugs@engestrom.ch>"> <span class="fn">Eric Engestrom</span></a>
</span></b>
<pre>Thanks!
Your fix is correct, although partial: the same bug appears again in the free()
a couple lines below.
I've added it as part of your patch and pushed it:
commit 4735ca71af9f741e2438104d543dc3c5a8107f35
Author: Andreas Baierl <<a href="mailto:ichgeh@imkreisrum.de">ichgeh@imkreisrum.de</a>>
Date: Mon Mar 11 16:04:08 2019 +0100
xf86drm: Fix segmentation fault while parsing device info
This fixes a bug, which was introduced with commit ee798b98
"xf85drm: de-duplicate drmParse{Platform.Host1x}{Bus,Device}Info".
where accessing *compatible[i] with i>0 results in a segfault.
Signed-off-by: Andreas Baierl <<a href="mailto:ichgeh@imkreisrum.de">ichgeh@imkreisrum.de</a>>
Fixes: ee798b98479709acdd8d "xf85drm: de-duplicate
drmParse{Platform.Host1x}{Bus,Device}Info"
Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@intel.com">eric.engestrom@intel.com</a>>
[Eric: add the same fix to the free() below]
Signed-off-by: Eric Engestrom <<a href="mailto:eric.engestrom@intel.com">eric.engestrom@intel.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>