<div dir="auto">I would like to deprecate the old prefix in the future after communicating with all chip customers, which is why the old prefix is not documented in the new bindings.<div dir="auto"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 25, 2019, 4:55 AM Daniel Thompson <<a href="mailto:daniel.thompson@linaro.org" target="_blank" rel="noreferrer">daniel.thompson@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Jun 25, 2019 at 12:05:28AM -0400, Brian Dodge wrote:<br>
> The vendor-prefixes.txt file properly refers to ArcticSand<br>
> as arctic but the driver bindings improperly abbreviated the<br>
> prefix to arc. This was a mistake in the original patch<br>
> <br>
> Signed-off-by: Brian Dodge <<a href="mailto:bdodge09@gmail.com" rel="noreferrer noreferrer" target="_blank">bdodge09@gmail.com</a>><br>
> ---<br>
> .../bindings/leds/backlight/arcxcnn_bl.txt | 24 +++++++++++++---------<br>
> 1 file changed, 14 insertions(+), 10 deletions(-)<br>
> <br>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt<br>
> index 230abde..9cf4c44 100644<br>
> --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt<br>
> +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt<br>
> @@ -1,8 +1,12 @@<br>
> -Binding for ArcticSand arc2c0608 LED driver<br>
> +Binding for ArcticSand arc family LED drivers<br>
> <br>
> Required properties:<br>
> -- compatible: should be "arc,arc2c0608"<br>
> -- reg: slave address<br>
> +- compatible: one of<br>
> + "arctic,arc1c0608"<br>
> + "arctic,arc2c0608"<br>
> + "arctic,arc3c0845"<br>
<br>
This is more a question for the DT folks than for Brian but...<br>
<br>
AFAICT this patch is fixing the binding for the ArcticSand devices to<br>
use the correct value from vendor-prefixes.yaml and has been previously<br>
discussed here:<br>
<a href="https://lkml.org/lkml/2018/9/25/726" rel="noreferrer noreferrer noreferrer" target="_blank">https://lkml.org/lkml/2018/9/25/726</a><br>
<br>
Currently this patch series just updates the DT bindings but the<br>
implementation also honours the old values (since there is a Chromebook<br>
in the wild that uses the current bindings).<br>
<br>
Hence I'm not clear whether the bindings should document the deprecated<br>
options too (e.g. make it easier to find the bindings doc with git grep<br>
and friends).<br>
<br>
<br>
Daniel.<br>
<br>
<br>
> +<br>
> +- reg: slave address<br>
> <br>
> Optional properties:<br>
> - default-brightness: brightness value on boot, value from: 0-4095<br>
> @@ -11,19 +15,19 @@ Optional properties:<br>
> - led-sources: List of enabled channels from 0 to 5.<br>
> See Documentation/devicetree/bindings/leds/common.txt<br>
> <br>
> -- arc,led-config-0: setting for register ILED_CONFIG_0<br>
> -- arc,led-config-1: setting for register ILED_CONFIG_1<br>
> -- arc,dim-freq: PWM mode frequence setting (bits [3:0] used)<br>
> -- arc,comp-config: setting for register CONFIG_COMP<br>
> -- arc,filter-config: setting for register FILTER_CONFIG<br>
> -- arc,trim-config: setting for register IMAXTUNE<br>
> +- arctic,led-config-0: setting for register ILED_CONFIG_0<br>
> +- arctic,led-config-1: setting for register ILED_CONFIG_1<br>
> +- arctic,dim-freq: PWM mode frequence setting (bits [3:0] used)<br>
> +- arctic,comp-config: setting for register CONFIG_COMP<br>
> +- arctic,filter-config: setting for register FILTER_CONFIG<br>
> +- arctic,trim-config: setting for register IMAXTUNE<br>
> <br>
> Note: Optional properties not specified will default to values in IC EPROM<br>
> <br>
> Example:<br>
> <br>
> arc2c0608@30 {<br>
> - compatible = "arc,arc2c0608";<br>
> + compatible = "arctic,arc2c0608";<br>
> reg = <0x30>;<br>
> default-brightness = <500>;<br>
> label = "lcd-backlight";<br>
> -- <br>
> 2.7.4<br>
> <br>
</blockquote></div>