<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; font-size: 16px;">Acked-by: Slava Abramov <slava.abramov@amd.com></span><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Colin King <colin.king@canonical.com><br> <b>Sent:</b> Friday, June 28, 2019 10:08:01 AM<br> <b>To:</b> Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org<br> <b>Cc:</b> kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org<br> <b>Subject:</b> [PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">From: Colin Ian King <colin.king@canonical.com><br> <br> The WARN_ON is currently throwing a warning when i is 65 or higher which<br> is off by one. It should be 64 or higher (64 queues from 0..63 inclusive),<br> so fix this off-by-one comparison.<br> <br> Fixes: 849aca9f9c03 ("drm/amdgpu: Move common code to amdgpu_gfx.c")<br> Signed-off-by: Colin Ian King <colin.king@canonical.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> index 74066e1466f7..c8d106c59e27 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> @@ -501,7 +501,7 @@ int amdgpu_gfx_enable_kcq(struct amdgpu_device *adev)<br> /* This situation may be hit in the future if a new HW<br> * generation exposes more than 64 queues. If so, the<br> * definition of queue_mask needs updating */<br> - if (WARN_ON(i > (sizeof(queue_mask)*8))) {<br> + if (WARN_ON(i >= (sizeof(queue_mask)*8))) {<br> DRM_ERROR("Invalid KCQ enabled: %d\n", i);<br> break;<br> }<br> -- <br> 2.20.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> </body> </html>