<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:paulepanter@users.sourceforge.net" title="Paul Menzel <paulepanter@users.sourceforge.net>"> <span class="fn">Paul Menzel</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WARNING: CPU: 0 PID: 370 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1355 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107296">bug 107296</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>paulepanter@users.sourceforge.net
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WARNING: CPU: 0 PID: 370 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1355 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107296#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WARNING: CPU: 0 PID: 370 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1355 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107296">bug 107296</a>
from <span class="vcard"><a class="email" href="mailto:paulepanter@users.sourceforge.net" title="Paul Menzel <paulepanter@users.sourceforge.net>"> <span class="fn">Paul Menzel</span></a>
</span></b>
<pre>Could some AMD developer please comment, on how to fix this? Tables(?)
containing “0 kHz” are apparently shipped by vendors, so what to do?
```
static bool verify_clock_values(struct dm_pp_clock_levels_with_voltage *clks)
{
int i;
if (clks->num_levels == 0)
return false;
for (i = 0; i < clks->num_levels; i++)
/* Ensure that the result is sane */
if (clks->data[i].clocks_in_khz == 0)
return false;
return true;
}
```
Should commit 00893681a0ff4 (drm/amd/display: Reject PPLib clock values if they
are invalid) [1] be reverted? Andrew, Tony, Harry?
<span class="quote">> drm/amd/display: Reject PPLib clock values if they are invalid</span >
>
<span class="quote">> We should be sticking with the default clock values if the values
> obtained from PPLib are bogus.</span >
>
<span class="quote">> Signed-off-by: Andrew Jiang <<a href="mailto:Andrew.Jiang@amd.com">Andrew.Jiang@amd.com</a>>
> Reviewed-by: Tony Cheng <<a href="mailto:Tony.Cheng@amd.com">Tony.Cheng@amd.com</a>>
> Acked-by: Harry Wentland <<a href="mailto:harry.wentland@amd.com">harry.wentland@amd.com</a>>
> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>></span >
PS: AMDGPU’s commit messages are too terse, and should be more elaborate.
[1]:
<a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=00893681a0ff41cacecabc3dafe0987593a3d5c5">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=00893681a0ff41cacecabc3dafe0987593a3d5c5</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>