<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:arkadiusz.hiler@intel.com" title="Arek Hiler <arkadiusz.hiler@intel.com>"> <span class="fn">Arek Hiler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Confusing Junk in the results: Last errno: 25, Inappropriate ioctl for device"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110354">bug 110354</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Confusing Junk in the results: Last errno: 25, Inappropriate ioctl for device"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110354#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Confusing Junk in the results: Last errno: 25, Inappropriate ioctl for device"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110354">bug 110354</a>
from <span class="vcard"><a class="email" href="mailto:arkadiusz.hiler@intel.com" title="Arek Hiler <arkadiusz.hiler@intel.com>"> <span class="fn">Arek Hiler</span></a>
</span></b>
<pre>There was a patch merged that resets errno in the few places where errno
pollution is likely and in the few places where it may require resetting:
commit a558c2e2405473f4157ca71638e5a111ebfa80d1
Author: Arkadiusz Hiler <<a href="mailto:arkadiusz.hiler@intel.com">arkadiusz.hiler@intel.com</a>>
Date: Tue Apr 9 17:21:41 2019 +0300
lib: Reset errno to 0 after isatty
Since igt_assert family of functions logs last errno we get a lot of
those: "Last errno: 25, Inappropriate ioctl for device"
isatty() seems to be the biggest offender in that area, so this patch
should limit amount of confusing messages significantly.
Cc: Martin Peres <<a href="mailto:martin.peres@linux.intel.com">martin.peres@linux.intel.com</a>>
Cc: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>>
Signed-off-by: Arkadiusz Hiler <<a href="mailto:arkadiusz.hiler@intel.com">arkadiusz.hiler@intel.com</a>>
Reviewed-by: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>>
commit 02b1706e8b1ca93a53d4ef0f9c484a6f1a0d18f2
Author: Arkadiusz Hiler <<a href="mailto:arkadiusz.hiler@intel.com">arkadiusz.hiler@intel.com</a>>
Date: Thu Apr 4 16:17:40 2019 +0300
lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
First, we set errno to 0 before doing select() to avoid random pollution
of the assert message with things like:
"Last errno: 25, Inappropriate ioctl for device"
Second, we log explicitly if we exceeded the timeout (ret == 0).
Third, if we fail the select() we log that with some explanation.
Cc: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>>
Cc: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>>
Signed-off-by: Arkadiusz Hiler <<a href="mailto:arkadiusz.hiler@intel.com">arkadiusz.hiler@intel.com</a>>
Reviewed-by: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>