<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Crashes / Resets From AMDGPU / Radeon VII" href="https://bugs.freedesktop.org/show_bug.cgi?id=110674#c115">Comment # 115</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Crashes / Resets From AMDGPU / Radeon VII" href="https://bugs.freedesktop.org/show_bug.cgi?id=110674">bug 110674</a> from <a class="email" href="mailto:tom@r.je" title="Tom B <tom@r.je>"> Tom B</a> <pre>I should have noted it earlier, but I had already tried reverting both "golden values" commits. I've no idea what it does but it didn't fix this crash. One thing that would be insightful would be logging every call to smum_send_msg_to_smc_with_parameter and printing out message/parameter: int smum_send_msg_to_smc_with_parameter(struct pp_hwmgr *hwmgr, uint16_t msg, uint32_t parameter) { This would cause a very busy log but we could see the last successful message that was sent and with the same log in 5.0.13 see if there are any obvious differences. It might be that the previous message causes the invalid state so knowing what that is could lead us towards the solution. I don't think I have time to try it today but if anyone is recompiling the code adding pr_err("msg: %d / parameter: %d\n", msg, parameter); to this function in smumgr.c would be a useful addition. Also, wants to try re-compiling, here's a quick guide for arch: 1. Get the kernel sources using asp as described here: <a href="https://wiki.archlinux.org/index.php/Kernel/Arch_Build_System">https://wiki.archlinux.org/index.php/Kernel/Arch_Build_System</a> navigate to the created linux/repos/core-x86_64 directory. 2. You will need to run makepkg -s once to get it to download the sources. 3. You can set the kernel version in PKGBUILD: e.g. _srcver=5.2.7-arch1 or _srcver=5.0.13-arch1 4. If you want to revert one or more commits put it in the prepare() block before local src: echo "$_kernelname" > localversion.20-pkgname git revert db64a2f43c1bc22c5ff2d22606000b8c3587d0ec --no-edit git revert f5e79735cab448981e245a41ee6cbebf0e334f61 --no-edit local src It will open your editor, if you don't want to use vi set: 5. For making changes to the code you need to make a patch. Open the src/archlinux-linux directory. The files you're interested in are in drivers/drm/gpu/drm/amd/powerplay likely hwmgr/vega20_hwmgr.c Make your changes to the code. You can't just re-run makepkg as it checks out the original version of the code. After making changes, navigate to the archlinux-linux directory and run git diff > ../../vii.patch 6. Add your patch to PKGBUILD source: source=( "$_srcname::git+<a href="https://git.archlinux.org/linux.git?signed#tag=v$_srcver">https://git.archlinux.org/linux.git?signed#tag=v$_srcver</a>" config # the main kernel config file 60-linux.hook # pacman hook for depmod 90-linux.hook # pacman hook for initramfs regeneration linux.preset # standard config files for mkinitcpio ramdisk vii.patch ) 7. I've been cheating with makepkg and getting it to skip hash checks as otherwise you have to generate the sha256sums for each patch you create. This is an extra step that only slows down testing. To compile/install run makepkg -si --skipinteg Because of the way makepkg works, it keeps the compiled code in the src directory. That means that although the first compile will take a few minutes, subsequent compiles will be a lot faster as it'll probably only be recompiling vega20_hwmgr.c</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>