<div dir="ltr"><div>Hi Sam,</div><div>Thank you for your email</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 22, 2020 at 5:21 AM Sam Ravnborg <<a href="mailto:sam@ravnborg.org">sam@ravnborg.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Kevin.<br>
<br>
On Fri, Feb 21, 2020 at 03:48:51PM +0800, Kevin Tang wrote:<br>
> From: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>><br>
> <br>
> The Unisoc DRM master device is a virtual device needed to list all<br>
> DPU devices or other display interface nodes that comprise the<br>
> graphics subsystem<br>
> <br>
> Cc: Orson Zhai <<a href="mailto:orsonzhai@gmail.com" target="_blank">orsonzhai@gmail.com</a>><br>
> Cc: Baolin Wang <<a href="mailto:baolin.wang@linaro.org" target="_blank">baolin.wang@linaro.org</a>><br>
> Cc: Chunyan Zhang <<a href="mailto:zhang.lyra@gmail.com" target="_blank">zhang.lyra@gmail.com</a>><br>
> Signed-off-by: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>><br>
> ---<br>
> .../devicetree/bindings/display/sprd/drm.yaml | 38 ++++++++++++++++++++++<br>
> 1 file changed, 38 insertions(+)<br>
> create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml<br>
> <br>
> diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml<br>
> new file mode 100644<br>
> index 0000000..1614ca6<br>
> --- /dev/null<br>
> +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml<br>
> @@ -0,0 +1,38 @@<br>
> +# SPDX-License-Identifier: GPL-2.0<br>
> +%YAML 1.2<br>
> +---<br>
> +$id: <a href="http://devicetree.org/schemas/display/sprd/drm.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/sprd/drm.yaml#</a><br>
> +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a><br>
> +<br>
> +title: Unisoc DRM master device<br>
> +<br>
> +maintainers:<br>
> + - David Airlie <<a href="mailto:airlied@linux.ie" target="_blank">airlied@linux.ie</a>><br>
> + - Daniel Vetter <<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>><br>
> + - Rob Herring <<a href="mailto:robh%2Bdt@kernel.org" target="_blank">robh+dt@kernel.org</a>><br>
> + - Mark Rutland <<a href="mailto:mark.rutland@arm.com" target="_blank">mark.rutland@arm.com</a>><br>
<br>
Rob is king of a super-maintainer.<br>
He should not be listed unless he has special<br>
relations to sprd.<br>
David + Daniel - likewise. Unless they are closely related to sprd drop<br>
them.<br></blockquote><div>Thanks for your reminder, i will do it.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> +<br>
> +description: |<br>
> + The Unisoc DRM master device is a virtual device needed to list all<br>
> + DPU devices or other display interface nodes that comprise the<br>
> + graphics subsystem.<br>
<br>
I wonder why you name it "Unisoc" when all other places references sprd.<br></blockquote><div>About vendor name, orson has already helped explain it, thanks you.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
> +<br>
> +properties:<br>
> + compatible:<br>
> + const: sprd,display-subsystem<br>
> +<br>
> + ports:<br>
> + description:<br>
> + Should contain a list of phandles pointing to display interface port<br>
> + of DPU devices.<br>
> +<br>
> +required:<br>
> + - compatible<br>
> + - ports<br>
So you want to force the driver to support ports - and no panel<br>
referenced directly?<br>
<br></blockquote><div>The ports is related to our display controller, not panel. </div><div>Panel driver is registered as mipi dsi device, so we put it in encoder(dsi) node.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +<br>
> +examples:<br>
> + - |<br>
> + display-subsystem {<br>
> + compatible = "sprd,display-subsystem";<br>
> + ports = <&dpu_out>;<br>
> + };<br>
> \ No newline at end of file<br>
Please fix.<br></blockquote><div>Ok, i will fix it. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Sam<br>
</blockquote></div></div>