<div dir="auto">Hm. I'm not sure offhand how to check if drmModeCrtcSetGamma is supported. I guess you could check if gamma size > 0 or something?</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 12, 2020, 02:39 Rohit Visavalia <<a href="mailto:RVISAVAL@xilinx.com">RVISAVAL@xilinx.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ilia Mirkin, Thanks for the review. By old-fashioned way you mean to say using drmModeCrtcSetGamma()? If yes then, it shows error as "failed to set gamma: Function no implemented" if any platform specific drm has no gamma property implemented. Current code shows error while running modetest for Xilinx drm as it doesn't supports gamma property and ideally it should not show error as gamma is optional property, so it doesn't serve the purpose of optional property. Please correct me if I am missing anything. Thanks Rohit > -----Original Message----- > From: Ilia Mirkin [mailto:<a href="mailto:imirkin@alum.mit.edu" target="_blank" rel="noreferrer">imirkin@alum.mit.edu</a>] > Sent: Tuesday, March 3, 2020 7:08 PM > To: Devarsh Thakkar <<a href="mailto:DEVARSHT@xilinx.com" target="_blank" rel="noreferrer">DEVARSHT@xilinx.com</a>> > Cc: Rohit Visavalia <<a href="mailto:RVISAVAL@xilinx.com" target="_blank" rel="noreferrer">RVISAVAL@xilinx.com</a>>; <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a>; > <a href="mailto:emil.velikov@collabora.com" target="_blank" rel="noreferrer">emil.velikov@collabora.com</a>; Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" target="_blank" rel="noreferrer">ville.syrjala@linux.intel.com</a>>; Hyun > Kwon <<a href="mailto:hyunk@xilinx.com" target="_blank" rel="noreferrer">hyunk@xilinx.com</a>>; Ranganathan Sk <<a href="mailto:rsk@xilinx.com" target="_blank" rel="noreferrer">rsk@xilinx.com</a>>; Dhaval > Rajeshbhai Shah <<a href="mailto:dshah@xilinx.com" target="_blank" rel="noreferrer">dshah@xilinx.com</a>>; Varunkumar Allagadapa > <<a href="mailto:VARUNKUM@xilinx.com" target="_blank" rel="noreferrer">VARUNKUM@xilinx.com</a>> > Subject: Re: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if > add_property_optional returns true > > EXTERNAL EMAIL > > Pretty sure the current code is right. If the GAMMA_LUT property can't be set, > it tries to set gamma the old-fashioned way. > > On Tue, Mar 3, 2020 at 8:12 AM Devarsh Thakkar <<a href="mailto:DEVARSHT@xilinx.com" target="_blank" rel="noreferrer">DEVARSHT@xilinx.com</a>> > wrote: > > > > Hi Rohit, > > > > This makes sense to me as gamma was implemented as optional property. > > Reviewed-By: "Devarsh Thakkar <<a href="mailto:devarsh.thakkar@xilinx.com" target="_blank" rel="noreferrer">devarsh.thakkar@xilinx.com</a>>" > > > > @<a href="mailto:emil.velikov@collabora.com" target="_blank" rel="noreferrer">emil.velikov@collabora.com</a>, @<a href="mailto:imirkin@alum.mit.edu" target="_blank" rel="noreferrer">imirkin@alum.mit.edu</a>, @Ville Syrjälä, > Could you please ack and help merge this patch if it also look good to you ? > > > > Regards, > > Devarsh > > > > > -----Original Message----- > > > From: Rohit Visavalia > > > Sent: 27 February 2020 00:40 > > > To: Rohit Visavalia <<a href="mailto:RVISAVAL@xilinx.com" target="_blank" rel="noreferrer">RVISAVAL@xilinx.com</a>>; > > > <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a>; <a href="mailto:imirkin@alum.mit.edu" target="_blank" rel="noreferrer">imirkin@alum.mit.edu</a>; > > > <a href="mailto:emil.velikov@collabora.com" target="_blank" rel="noreferrer">emil.velikov@collabora.com</a> > > > Cc: Hyun Kwon <<a href="mailto:hyunk@xilinx.com" target="_blank" rel="noreferrer">hyunk@xilinx.com</a>>; Ranganathan Sk <<a href="mailto:rsk@xilinx.com" target="_blank" rel="noreferrer">rsk@xilinx.com</a>>; > > > Dhaval Rajeshbhai Shah <<a href="mailto:dshah@xilinx.com" target="_blank" rel="noreferrer">dshah@xilinx.com</a>>; Varunkumar Allagadapa > > > <<a href="mailto:VARUNKUM@xilinx.com" target="_blank" rel="noreferrer">VARUNKUM@xilinx.com</a>>; Devarsh Thakkar <<a href="mailto:DEVARSHT@xilinx.com" target="_blank" rel="noreferrer">DEVARSHT@xilinx.com</a>> > > > Subject: RE: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() > > > only if add_property_optional returns true > > > > > > Gentle reminder. > > > > > > + Ilia Mirkin, +Emil Velikov. > > > > > > Thanks & Regards, > > > Rohit > > > > > > > -----Original Message----- > > > > From: Rohit Visavalia [mailto:<a href="mailto:rohit.visavalia@xilinx.com" target="_blank" rel="noreferrer">rohit.visavalia@xilinx.com</a>] > > > > Sent: Tuesday, February 25, 2020 3:08 PM > > > > To: <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a> > > > > Cc: Hyun Kwon <<a href="mailto:hyunk@xilinx.com" target="_blank" rel="noreferrer">hyunk@xilinx.com</a>>; Ranganathan Sk <<a href="mailto:rsk@xilinx.com" target="_blank" rel="noreferrer">rsk@xilinx.com</a>>; > > > > Dhaval Rajeshbhai Shah <<a href="mailto:dshah@xilinx.com" target="_blank" rel="noreferrer">dshah@xilinx.com</a>>; Varunkumar Allagadapa > > > > <<a href="mailto:VARUNKUM@xilinx.com" target="_blank" rel="noreferrer">VARUNKUM@xilinx.com</a>>; Devarsh Thakkar <<a href="mailto:DEVARSHT@xilinx.com" target="_blank" rel="noreferrer">DEVARSHT@xilinx.com</a>>; > > > > Rohit Visavalia <<a href="mailto:RVISAVAL@xilinx.com" target="_blank" rel="noreferrer">RVISAVAL@xilinx.com</a>> > > > > Subject: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only > > > > if add_property_optional returns true > > > > > > > > gamma is a optional property then also it prints error message, so > > > > set gamma only if add_property_optional() returns true. > > > > > > > > Signed-off-by: Rohit Visavalia <<a href="mailto:rohit.visavalia@xilinx.com" target="_blank" rel="noreferrer">rohit.visavalia@xilinx.com</a>> > > > > --- > > > > tests/modetest/modetest.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c > > > > index b907ab3..379b9ea 100644 > > > > --- a/tests/modetest/modetest.c > > > > +++ b/tests/modetest/modetest.c > > > > @@ -1138,7 +1138,7 @@ static void set_gamma(struct device *dev, > > > > unsigned crtc_id, unsigned fourcc) > > > > > > > > add_property_optional(dev, crtc_id, "DEGAMMA_LUT", 0); > > > > add_property_optional(dev, crtc_id, "CTM", 0); > > > > - if (!add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) { > > > > + if (add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) > > > > + { > > > > uint16_t r[256], g[256], b[256]; > > > > > > > > for (i = 0; i < 256; i++) { > > > > -- > > > > 2.7.4 > > </blockquote></div>