<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 9, 2020 at 10:58 PM Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com">ville.syrjala@linux.intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jun 09, 2020 at 03:57:04AM +0800, Cyrus Lien wrote:<br> > According to EDID spec, table 3.26, byte #6 and #8, which said "Minimum<br> > rate value shall be less than or equal to maximum rate value". The minimum<br> > horizontal/vertical rate value is able to be equal to maximum horizontal/<br> > veritcal rate value.<br> <br> How does that justifiy ignoring the min value?<br> <br></blockquote><div><span class="gmail_default" style="font-size:small">Indeed, this patch does not make sense.</span></div><div><span class="gmail_default" style="font-size:small">Setting</span> <span class="gmail_default" style="font-size:small">minimum horizontal rate equal to maximum horizontal rate is a request come from AMD Windows graphic driver for support freesync (I'm not sure if linux AMD driver also require it). </span></div><div><span class="gmail_default" style="font-size:small">The problem is mode_in_hsync_range always return false except the mode's hsync exactly equal to hmax and hmin.</span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">Add print in mode_in_hsync_range():</span></div><div><span class="gmail_default" style="font-size:small">[drm] mode_in_hsync_range 1920x1200: hsync: 94, hmax: 110, hmix:110<br>[drm] mode_in_hsync_range 1920x1200: hsync: 107, hmax: 110, hmix:110<br>[drm] mode_in_hsync_range 1920x1200: hsync: 152, hmax: 110, hmix:110<br>[drm] mode_in_hsync_range 1920x1440: hsync: 90, hmax: 110, hmix:110<br>[drm] mode_in_hsync_range 1920x1440: hsync: 113, hmax: 110, hmix:110<br>[drm] mode_in_hsync_range 1920x1440: hsync: 183, hmax: 110, hmix:110</span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">Is it available to get or calculate the hmax, hmix value from other fields in EDID ?</span></div><div><span class="gmail_default" style="font-size:small">Would you please provide some advice or directions to solve this problem ? Thank you and appreciated the help.</span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">edid-decode (hex):<br><br>00 ff ff ff ff ff ff 00 06 af 9b 32 00 00 00 00 <br>00 1e 01 04 b5 26 15 78 03 1f 95 a5 53 35 b5 26 <br>0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 <br>01 01 01 01 01 01 70 d0 00 a0 f0 70 3e 80 30 20 <br>35 00 7d d6 10 00 00 1a 00 00 00 fd 00 32 5a 6e <br>6e 17 01 11 01 e0 60 20 50 3c 00 00 00 fe 00 34 <br>34 54 52 4e 15 42 31 37 33 5a 41 4e 00 00 00 00 <br>00 05 81 01 28 00 12 00 00 0b 01 0a 20 20 01 af <br><br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <br><br>----------------<br><br>EDID version: 1.4<br>Manufacturer: AUO Model 12955 Serial Number 0<br>Made in year 2020<br>Digital display<br>10 bits per primary color channel<br>DisplayPort interface<br>Maximum image size: 38 cm x 21 cm<br>Gamma: 2.20<br>Supported color formats: RGB 4:4:4<br>First detailed timing includes the native pixel format and preferred refresh rate<br>Display is continuous frequency<br>Color Characteristics<br> Red: 0.6445, 0.3251<br> Green: 0.2099, 0.7099<br> Blue: 0.1503, 0.0595<br> White: 0.3134, 0.3291<br>Established Timings I & II: none<br>Standard Timings: none<br>Detailed mode: Clock 533.600 MHz, 381 mm x 214 mm<br> 3840 3888 3920 4000 ( 48 32 80)<br> 2160 2163 2168 2222 ( 3 5 54)<br> +hsync -vsync<br> VertFreq: 60.036 Hz, HorFreq: 133.400 kHz<br>Display Range Limits<br> Monitor ranges (Bare Limits): 50-90 Hz V, 110-110 kHz H, max dotclock 230 MHz<br>Alphanumeric Data String: 44TRN<br>Manufacturer-Specified Display Descriptor (0x00): 00 00 00 05 81 01 28 00 12 00 00 0b 01 0a 20 20 ......(....... <br>Has 1 extension block<br>Checksum: 0xaf<br><br>----------------<br></span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > <br> > This change check if h/v-sync excess maximum horizontal/vertical rate if<br> > hmin equal to hmax or vmin equal to vmax.<br> > <br> > Signed-off-by: Cyrus Lien <<a href="mailto:cyrus.lien@canonical.com" target="_blank">cyrus.lien@canonical.com</a>><br> > ---<br> > drivers/gpu/drm/drm_edid.c | 6 ++++++<br> > 1 file changed, 6 insertions(+)<br> > <br> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c<br> > index fed653f13c26..23878320eabd 100644<br> > --- a/drivers/gpu/drm/drm_edid.c<br> > +++ b/drivers/gpu/drm/drm_edid.c<br> > @@ -2674,6 +2674,9 @@ mode_in_hsync_range(const struct drm_display_mode *mode,<br> > hmax += ((t[4] & 0x08) ? 255 : 0);<br> > hsync = drm_mode_hsync(mode);<br> > <br> > + if (hmax == hmin)<br> > + return (hsync <= hmax);<br> > +<br> > return (hsync <= hmax && hsync >= hmin);<br> > }<br> > <br> > @@ -2691,6 +2694,9 @@ mode_in_vsync_range(const struct drm_display_mode *mode,<br> > vmax += ((t[4] & 0x02) ? 255 : 0);<br> > vsync = drm_mode_vrefresh(mode);<br> > <br> > + if (vmax == vmin)<br> > + return (vsync <= vmax);<br> > +<br> > return (vsync <= vmax && vsync >= vmin);<br> > }<br> > <br> > -- <br> > 2.25.1<br> > <br> > _______________________________________________<br> > dri-devel mailing list<br> > <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br> > <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br> <br> -- <br> Ville Syrjälä<br> Intel<br> </blockquote></div></div>