<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 17, 2020 at 2:40 AM Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">  Hi,<br>
<br>
> +             if (!devm_request_mem_region(&vgdev->vdev->dev,<br>
> +                                          vgdev->host_visible_region.addr,<br>
> +                                          vgdev->host_visible_region.len,<br>
> +                                          dev_name(&vgdev->vdev->dev))) {<br>
> +                     DRM_ERROR("Could not reserve host visible region\n");<br>
> +                     goto err_vqs;<br>
> +             }<br>
<br>
> +     if (vgdev->has_host_visible) {<br>
> +             devm_release_mem_region(&vgdev->vdev->dev,<br>
> +                                     vgdev->host_visible_region.addr,<br>
> +                                     vgdev->host_visible_region.len);<br>
> +     }<br>
<br>
Hmm. isn't it the point of the managed apis that the release happens<br>
automatically?  I think you don't need the devm_release_mem_region<br>
call (it doesn't break things though).<br></blockquote><div><br></div><div>Ack, good catch.  Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
take care,<br>
  Gerd<br>
<br>
</blockquote></div></div>