<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 30, 2020 at 4:48 AM Dan Carpenter <<a href="mailto:dan.carpenter@oracle.com">dan.carpenter@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is freed both here and in the caller (virtio_gpu_vram_map()) so<br>
it's a double free. The correct place is only in the caller.<br>
<br>
Fixes: 16845c5d5409 ("drm/virtio: implement blob resources: implement vram object")<br>
Signed-off-by: Dan Carpenter <<a href="mailto:dan.carpenter@oracle.com" target="_blank">dan.carpenter@oracle.com</a>><br>
---<br>
drivers/gpu/drm/virtio/virtgpu_vq.c | 4 +---<br>
1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c<br>
index 72586cd8cc4c..3f200306c9d7 100644<br>
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c<br>
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c<br>
@@ -1212,10 +1212,8 @@ int virtio_gpu_cmd_map(struct virtio_gpu_device *vgdev,<br>
struct virtio_gpu_resp_map_info *resp_buf;<br>
<br>
resp_buf = kzalloc(sizeof(*resp_buf), GFP_KERNEL);<br>
- if (!resp_buf) {<br>
- virtio_gpu_array_put_free(objs);<br>
+ if (!resp_buf)<br>
return -ENOMEM;<br>
- }<br>
<br>
cmd_p = virtio_gpu_alloc_cmd_resp<br>
(vgdev, virtio_gpu_cmd_resource_map_cb, &vbuf, sizeof(*cmd_p),<br>
-- <br>
2.28.0<br></blockquote><div>Reviewed-by: Gurchetan Singh <<a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a>><br></div><div> </div></div></div>