<div dir="ltr"><div>Hi Rob, </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">Rob Herring <<a href="mailto:robh%2Bdt@kernel.org">robh+dt@kernel.org</a>> 于2020年12月1日周二上午4:31写道： </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Nov 30, 2020 at 7:29 AM Kevin Tang <<a href="mailto:kevin3.tang@gmail.com" target="_blank">kevin3.tang@gmail.com</a>> wrote: > > From: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > Cc: Orson Zhai <<a href="mailto:orsonzhai@gmail.com" target="_blank">orsonzhai@gmail.com</a>> > Cc: Chunyan Zhang <<a href="mailto:zhang.lyra@gmail.com" target="_blank">zhang.lyra@gmail.com</a>> > Signed-off-by: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > --- > .../display/sprd/sprd,sharkl3-dsi-host.yaml | 107 +++++++++++++++++++++ > .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 84 ++++++++++++++++ > 2 files changed, 191 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > new file mode 100644 > index 0000000..fe0e89d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: <a href="http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#</a> > +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a> > + > +title: Unisoc MIPI DSI Controller > + > +maintainers: > + - Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > + > +properties: > + compatible: > + const: sprd,sharkl3-dsi-host > + > + reg: > + maxItems: 1 > + description: > + Physical base address and length of the registers set for the device. > + > + interrupts: > + maxItems: 2 > + description: > + Should contain DSI interrupt. > + > + clocks: > + minItems: 1 > + > + clock-names: > + items: > + - const: clk_src_96m > + > + power-domains: > + maxItems: 1 > + description: A phandle to DSIM power domain node > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the input endpoint, usually coming from > + the associated DPU. > + port@1: > + type: object > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the output endpoint, usually output to > + the associated DPHY. > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + - port@1 > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/sprd,sc9860-clk.h> > + dsi: dsi@63100000 { > + compatible = "sprd,sharkl3-dsi-host"; > + reg = <0x63100000 0x1000>; > + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>; > + clock-names = "clk_src_96m"; > + clocks = <&pll CLK_TWPLL_96M>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + dsi_in: endpoint { > + remote-endpoint = <&dpu_out>; > + }; > + }; > + port@1 { > + reg = <1>; > + dsi_out: endpoint { > + remote-endpoint = <&dphy_in>; > + }; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > new file mode 100644 > index 0000000..b4715d5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: <a href="http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-phy.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-phy.yaml#</a> > +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a> > + > +title: Unisoc MIPI DSI-PHY (D-PHY) > + > +maintainers: > + - Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > + > +properties: > + compatible: > + const: sprd,sharkl3-dsi-phy > + > + reg: > + maxItems: 1 > + description: > + Must be the dsi controller base address. > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the output endpoint, usually output to > + the associated panel. > + port@1: For PHYs, we use the PHY binding, not the graph binding. Please follow what practically every other DSI PHY does. </blockquote><div>It seems that the dphy driver does not need to exist alone, so i remove dphy and dsi graph binding, merge the dphy driver into the dsi driver.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Rob </blockquote></div></div>