<div dir="ltr"><div>Hi Rob, </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">Rob Herring <<a href="mailto:robh%2Bdt@kernel.org">robh+dt@kernel.org</a>> äºŽ2020å¹´12æœˆ1æ—¥å‘¨äºŒ ä¸Šåˆ4:31å†™é“ï¼š </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Nov 30, 2020 at 7:29 AM Kevin Tang <<a href="mailto:kevin3.tang@gmail.com" target="_blank">kevin3.tang@gmail.com</a>> wrote: > > From: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > Cc: Orson Zhai <<a href="mailto:orsonzhai@gmail.com" target="_blank">orsonzhai@gmail.com</a>> > Cc: Chunyan Zhang <<a href="mailto:zhang.lyra@gmail.com" target="_blank">zhang.lyra@gmail.com</a>> > Signed-off-by: Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > --- >Â .../display/sprd/sprd,sharkl3-dsi-host.yamlÂ Â Â Â | 107 +++++++++++++++++++++ >Â .../display/sprd/sprd,sharkl3-dsi-phy.yamlÂ Â Â Â Â |Â 84 ++++++++++++++++ >Â 2 files changed, 191 insertions(+) >Â create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml >Â create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > new file mode 100644 > index 0000000..fe0e89d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: <a href="http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#</a> > +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a> > + > +title: Unisoc MIPI DSI Controller > + > +maintainers: > +Â - Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > + > +properties: > +Â compatible: > +Â Â const: sprd,sharkl3-dsi-host > + > +Â reg: > +Â Â maxItems: 1 > +Â Â description: > +Â Â Â Physical base address and length of the registers set for the device. > + > +Â interrupts: > +Â Â maxItems: 2 > +Â Â description: > +Â Â Â Should contain DSI interrupt. > + > +Â clocks: > +Â Â minItems: 1 > + > +Â clock-names: > +Â Â items: > +Â Â Â - const: clk_src_96m > + > +Â power-domains: > +Â Â maxItems: 1 > +Â Â description: A phandle to DSIM power domain node > + > +Â ports: > +Â Â type: object > + > +Â Â properties: > +Â Â Â "#address-cells": > +Â Â Â Â const: 1 > + > +Â Â Â "#size-cells": > +Â Â Â Â const: 0 > + > +Â Â Â port@0: > +Â Â Â Â type: object > +Â Â Â Â description: > +Â Â Â Â Â A port node with endpoint definitions as defined in > +Â Â Â Â Â Documentation/devicetree/bindings/media/video-interfaces.txt. > +Â Â Â Â Â That port should be the input endpoint, usually coming from > +Â Â Â Â Â the associated DPU. > +Â Â Â port@1: > +Â Â Â Â type: object > +Â Â Â Â description: > +Â Â Â Â Â A port node with endpoint definitions as defined in > +Â Â Â Â Â Documentation/devicetree/bindings/media/video-interfaces.txt. > +Â Â Â Â Â That port should be the output endpoint, usually output to > +Â Â Â Â Â the associated DPHY. > + > +Â Â required: > +Â Â Â - "#address-cells" > +Â Â Â - "#size-cells" > +Â Â Â - port@0 > +Â Â Â - port@1 > + > +Â Â additionalProperties: false > + > +required: > +Â - compatible > +Â - reg > +Â - interrupts > +Â - clocks > +Â - clock-names > +Â - ports > + > +additionalProperties: false > + > +examples: > +Â - | > +Â Â #include <dt-bindings/interrupt-controller/arm-gic.h> > +Â Â #include <dt-bindings/clock/sprd,sc9860-clk.h> > +Â Â dsi: dsi@63100000 { > +Â Â Â Â compatible = "sprd,sharkl3-dsi-host"; > +Â Â Â Â reg = <0x63100000 0x1000>; > +Â Â Â Â interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>, > +Â Â Â Â Â <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>; > +Â Â Â Â clock-names = "clk_src_96m"; > +Â Â Â Â clocks = <&pll CLK_TWPLL_96M>; > +Â Â Â Â ports { > +Â Â Â Â Â Â #address-cells = <1>; > +Â Â Â Â Â Â #size-cells = <0>; > +Â Â Â Â Â Â port@0 { > +Â Â Â Â Â Â Â Â reg = <0>; > +Â Â Â Â Â Â Â Â dsi_in: endpoint { > +Â Â Â Â Â Â Â Â Â Â remote-endpoint = <&dpu_out>; > +Â Â Â Â Â Â Â Â }; > +Â Â Â Â Â Â }; > +Â Â Â Â Â Â port@1 { > +Â Â Â Â Â Â Â Â reg = <1>; > +Â Â Â Â Â Â Â Â dsi_out: endpoint { > +Â Â Â Â Â Â Â Â Â Â remote-endpoint = <&dphy_in>; > +Â Â Â Â Â Â Â Â }; > +Â Â Â Â Â Â }; > +Â Â Â Â }; > +Â Â }; > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > new file mode 100644 > index 0000000..b4715d5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: <a href="http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-phy.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-phy.yaml#</a> > +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a> > + > +title: Unisoc MIPI DSI-PHY (D-PHY) > + > +maintainers: > +Â - Kevin Tang <<a href="mailto:kevin.tang@unisoc.com" target="_blank">kevin.tang@unisoc.com</a>> > + > +properties: > +Â compatible: > +Â Â const: sprd,sharkl3-dsi-phy > + > +Â reg: > +Â Â maxItems: 1 > +Â Â description: > +Â Â Â Must be the dsi controller base address. > + > +Â ports: > +Â Â type: object > + > +Â Â properties: > +Â Â Â "#address-cells": > +Â Â Â Â const: 1 > + > +Â Â Â "#size-cells": > +Â Â Â Â const: 0 > + > +Â Â Â port@0: > +Â Â Â Â type: object > +Â Â Â Â description: > +Â Â Â Â Â A port node with endpoint definitions as defined in > +Â Â Â Â Â Documentation/devicetree/bindings/media/video-interfaces.txt. > +Â Â Â Â Â That port should be the output endpoint, usually output to > +Â Â Â Â Â the associated panel. > +Â Â Â port@1: For PHYs, we use the PHY binding, not the graph binding. Please follow what practically every other DSI PHY does. </blockquote><div>It seems that the dphy driver does not need to exist alone, so i remove dphy and dsi graph binding, merge the dphy driver into the dsi driver.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Rob </blockquote></div></div>