<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-size: 11pt;">++Siqueira.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-size: 11pt;"><br>
</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-size: 11pt;">Regards,</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-size: 11pt;">Bindu </span><br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Tuesday, December 29, 2020 10:07 AM<br>
<b>To:</b> Linus Torvalds <torvalds@linux-foundation.org>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Wu, Hersen <hersenxs.wu@amd.com><br>
<b>Cc:</b> Dave Airlie <airlied@gmail.com>; Pavic, Josip <Josip.Pavic@amd.com>; R, Bindu <Bindu.R@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Daniel Vetter <daniel.vetter@ffwll.ch>; LKML <linux-kernel@vger.kernel.org>; dri-devel <dri-devel@lists.freedesktop.org><br>
<b>Subject:</b> Re: [git pull] drm fixes for 5.11-rc1</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On Thu, Dec 24, 2020 at 5:28 PM Linus Torvalds<br>
<torvalds@linux-foundation.org> wrote:<br>
><br>
> On Wed, Dec 23, 2020 at 6:29 PM Dave Airlie <airlied@gmail.com> wrote:<br>
> ><br>
> > Xmas eve pull request present. Just some fixes that trickled in this<br>
> > past week. Mostly amdgpu fixes, with a dma-buf/mips build fix and some<br>
> > misc komeda fixes.<br>
><br>
> Well, I already pulled and pushed out my merge, but only noticed<br>
> afterwards that clang complains about this, and I think it's a real<br>
> bug:<br>
><br>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_mpc.c:475:6: warning:<br>
> variable 'val' is used uninitialized whenever 'if' condition is<br>
> false [-Wsometimes-uninitialized]<br>
><br>
> and it sure is true: the code literally does<br>
><br>
> uint32_t val;<br>
><br>
> if (opp_id < MAX_OPP && REG(MUX[opp_id]))<br>
> REG_GET(MUX[opp_id], MPC_OUT_MUX, &val);<br>
><br>
> return val;<br>
><br>
> so clearly 'val' isn't initialized if that if-statement isn't true.<br>
><br>
> I assume 'opp_id' is always presumed to be valid, but that code really<br>
> is disgusting.<br>
><br>
> Just make it return 0 (or whatever) for invalid, possibly together<br>
> with a WARN_ON_ONCE(). Ok?<br>
<br>
Harry, Nick, Hersen,<br>
<br>
Can you take a look?<br>
<br>
Thanks,<br>
<br>
Alex<br>
<br>
><br>
> Linus<br>
> _______________________________________________<br>
> dri-devel mailing list<br>
> dri-devel@lists.freedesktop.org<br>
> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cbindu.r%40amd.com%7Cae8f547c9287426b9b9408d8ac0b7b73%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637448512618562550%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4gcQRS3HI4u1UEWu35Ze1w5CLWmAof5nouCFQoKEQD0%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cbindu.r%40amd.com%7Cae8f547c9287426b9b9408d8ac0b7b73%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637448512618562550%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4gcQRS3HI4u1UEWu35Ze1w5CLWmAof5nouCFQoKEQD0%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>