<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 25, 2021 at 5:05 PM Simon Ser <<a href="mailto:contact@emersion.fr">contact@emersion.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐<br>
<br>
On Monday, January 25th, 2021 at 5:00 PM, Mario Kleiner <<a href="mailto:mario.kleiner.de@gmail.com" target="_blank">mario.kleiner.de@gmail.com</a>> wrote:<br>
<br>
> On Mon, Jan 25, 2021 at 1:14 PM Simon Ser <<a href="mailto:contact@emersion.fr" target="_blank">contact@emersion.fr</a>> wrote:<br>
><br>
> > > This is not an uapi defintion anyway so fixing should be fine.<br>
> ><br>
> > Oh, my bad, I thought this was in drm_mode.h, but it's not. Then yeah<br>
> ><br>
> > should be completely fine to fix it.<br>
><br>
> Good! The beginning of the end of a sad story ;). So i guess i can<br>
> get your r-b's for it?<br>
<br>
Sorry, I haven't verified that this wouldn't break the world, so I'm<br>
not comfortable giving a R-b.<br>
<br></blockquote><div><br></div><div>Breaking the world is pretty unlikely for an unused #define, but I understand.</div><div><br></div><div>I guess Ville will have access to the relevant spec to verify: It is the CTA-861-G spec, table 44 in section 6.9 and also specifically section 6.9.1.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Will this fix propagate into igt and libdrm? Or are separate fixup patches needed?<br>
<br>
No, since this is not part of UAPI.<br></blockquote><div><br></div><div>Ok. I'll submit patches once this one landed in the kernel.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> Simon, could you let the Kodi devs know in case you have a line to<br>
> them? I didn't know that there is even one more real-world HDR client<br>
> for Linux, apart from AMD's amdvlk Vulkan driver, which does things<br>
> right and doesn't need fixing.<br>
<br>
Seems like Kodi hardcodes the bad version:<br>
<br>
<a href="https://github.com/xbmc/xbmc/blob/aa5c2e79c069ba7d0ab1d8ad930e4294bf554680/xbmc/cores/VideoPlayer/Buffers/VideoBufferDRMPRIME.h#L24" rel="noreferrer" target="_blank">https://github.com/xbmc/xbmc/blob/aa5c2e79c069ba7d0ab1d8ad930e4294bf554680/xbmc/cores/VideoPlayer/Buffers/VideoBufferDRMPRIME.h#L24</a><br>
<br></blockquote><div><br></div><div>Thanks. I've filed an issue to them under:</div><div><br></div><div><a href="https://github.com/xbmc/xbmc/issues/19122">https://github.com/xbmc/xbmc/issues/19122</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Maybe we should add the good version in UAPI header?<br></blockquote><div><br></div><div>I'm scared that future HDR definitions would be as carefully done and reviewed as this one, given how much harder it would be to fix them :/<br></div><div>But maybe that's just exhausted me who spent too many weeks dealing with HDR bugs everywhere.</div><div><br></div><div>-mario</div><div><br></div></div></div>