<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 6, 2021 at 1:47 PM Vivek Kasireddy <<a href="mailto:vivek.kasireddy@intel.com" target="_blank">vivek.kasireddy@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">If support for Blob resources is available, then dumb BOs created<br>
by the driver can be considered as guest Blobs.<br>
<br>
v2: Don't skip transfer and flush commands as part of plane update<br>
as the device may have created a shared mapping. (Gerd)<br>
<br>
Cc: Gerd Hoffmann <<a href="mailto:kraxel@redhat.com" target="_blank">kraxel@redhat.com</a>><br>
Signed-off-by: Vivek Kasireddy <<a href="mailto:vivek.kasireddy@intel.com" target="_blank">vivek.kasireddy@intel.com</a>><br>
---<br>
drivers/gpu/drm/virtio/virtgpu_gem.c | 8 ++++++++<br>
drivers/gpu/drm/virtio/virtgpu_object.c | 3 +++<br>
2 files changed, 11 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c<br>
index 8502400b2f9c..5f49fb1cce65 100644<br>
--- a/drivers/gpu/drm/virtio/virtgpu_gem.c<br>
+++ b/drivers/gpu/drm/virtio/virtgpu_gem.c<br>
@@ -64,6 +64,7 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv,<br>
{<br>
struct drm_gem_object *gobj;<br>
struct virtio_gpu_object_params params = { 0 };<br>
+ struct virtio_gpu_device *vgdev = dev->dev_private;<br>
int ret;<br>
uint32_t pitch;<br>
<br>
@@ -79,6 +80,13 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv,<br>
params.height = args->height;<br>
params.size = args->size;<br>
params.dumb = true;<br>
+<br>
+ if (vgdev->has_resource_blob) {<br>
+ params.blob_mem = VIRTGPU_BLOB_MEM_GUEST;<br>
+ params.blob_flags = VIRTGPU_BLOB_FLAG_USE_SHAREABLE;<br></blockquote><div><br></div><div>This creates some log spam with crosvm + virgl_3d + vanilla linux, since transfers don't work for guest blobs. Two options:</div><div><br></div><div>a) Add vgdev->has_virgl_3d check and don't create a guest blob in that case.</div><div>b) The interactions between TRANSFER_TO_HOST_2D and VIRTGPU_BLOB_MEM_GUEST are a bit under-defined in the spec. Though since you don't have a host side resource, you can safely skip the transfer and crosvm can be modified to do the right thing in case of RESOURCE_FLUSH. </div><div><br></div><div>It makes a ton of sense to have a explicit udmabuf-like flag ("BLOB_FLAG_CREATE_GUEST_HANDLE" or "BLOB_FLAG_HANDLE_FROM_GUEST" -- want to host OS agnostic -- any other ideas?), especially with 3d mode. For now, implicit udmabuf + dumb should be fine since the QEMU patches have been floating around for a while and should land soon for future use cases.<br></div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ params.blob = true;<br>
+ }<br></blockquote><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
ret = virtio_gpu_gem_create(file_priv, dev, ¶ms, &gobj,<br>
&args->handle);<br>
if (ret)<br>
diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c<br>
index 4ff1ec28e630..f648b0e24447 100644<br>
--- a/drivers/gpu/drm/virtio/virtgpu_object.c<br>
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c<br>
@@ -254,6 +254,9 @@ int virtio_gpu_object_create(struct virtio_gpu_device *vgdev,<br>
}<br>
<br>
if (params->blob) {<br>
+ if (params->blob_mem == VIRTGPU_BLOB_MEM_GUEST)<br>
+ bo->guest_blob = true;<br>
+<br>
virtio_gpu_cmd_resource_create_blob(vgdev, bo, params,<br>
ents, nents);<br>
} else if (params->virgl) {<br>
-- <br>
2.26.2<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div></div>