<div class="__aliyun_email_body_block"><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><span  class=" __aliyun_node_has_color __aliyun_node_has_bgcolor" style="margin:.0px;padding:.0px;border:.0px;outline:.0px;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-indent:.0px;text-transform:none;widows:2;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;text-align:left;background-color:#ffffff;float:none;display:inline;">    I am so sorry for my mistakes. </span><br  style="color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;orphans:2;text-align:start;text-indent:.0px;text-transform:none;white-space:normal;widows:2;word-spacing:.0px;"><span  class=" __aliyun_node_has_color __aliyun_node_has_bgcolor" style="margin:.0px;padding:.0px;border:.0px;outline:.0px;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-indent:.0px;text-transform:none;widows:2;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;text-align:left;background-color:#ffffff;float:none;display:inline;">    I am a newbie trying to learn how to fix errors found by <span  style="color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-align:start;text-indent:.0px;text-transform:none;widows:2;background-color:#ffffff;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline;">Coccinelle</span>.</span><br  style="color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;orphans:2;text-align:start;text-indent:.0px;text-transform:none;white-space:normal;widows:2;word-spacing:.0px;"><br  style="color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;orphans:2;text-align:start;text-indent:.0px;text-transform:none;white-space:normal;widows:2;word-spacing:.0px;"><span  class=" __aliyun_node_has_color __aliyun_node_has_bgcolor" style="margin:.0px;padding:.0px;border:.0px;outline:.0px;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-indent:.0px;text-transform:none;widows:2;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;text-align:left;background-color:#ffffff;float:none;display:inline;">    Currently, I just run scripts/checkpatch.pl.</span></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><span  class=" __aliyun_node_has_color __aliyun_node_has_bgcolor" style="margin:.0px;padding:.0px;border:.0px;outline:.0px;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-indent:.0px;text-transform:none;widows:2;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;text-align:left;background-color:#ffffff;float:none;display:inline;">    <span  style="color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-align:left;text-indent:.0px;text-transform:none;widows:2;background-color:#ffffff;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline;">I will do basic build with the patch before sending it in the next time. Thank you for your advice.</span></span></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><span  class=" __aliyun_node_has_color __aliyun_node_has_bgcolor" style="margin:.0px;padding:.0px;border:.0px;outline:.0px;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;text-indent:.0px;text-transform:none;widows:2;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;color:#171a1d;font-family:Microsoft YaHei,Segoe UI,system-ui,Roboto,Droid Sans,Helvetica Neue,sans-serif,Tahoma,Segoe UI SymbolMyanmar Text,微软雅黑;text-align:left;background-color:#ffffff;float:none;display:inline;"><br ></span></span></div><blockquote  style="margin-right:.0px;margin-top:.0px;margin-bottom:.0px;"><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">------------------------------------------------------------------</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">发件人：Krzysztof Kozlowski <krzk@kernel.org></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">发送时间：2021年4月16日(星期五) 17:07</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">收件人：Yang Li <yang.lee@linux.alibaba.com></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">抄　送：tomba <tomba@kernel.org>; airlied <airlied@linux.ie>; daniel <daniel@ffwll.ch>; dri-devel <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">主　题：Re: [PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><br ></span></div>On Mon, 22 Mar 2021 at 09:53, Yang Li <yang.lee@linux.alibaba.com> wrote:<br >><br >> fixed the following coccicheck:<br >> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with<br >> no primary handler requested without IRQF_ONESHOT<br >><br >> Make sure threaded IRQs without a primary handler are always request<br >> with IRQF_ONESHOT<br >><br >> Reported-by: Abaci Robot <abaci@linux.alibaba.com><br >> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com><br >> ---<br >>  drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-<br >>  1 file changed, 1 insertion(+), 1 deletion(-)<br >><br >> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c<br >> index b31d750..844cb0b 100644<br >> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c<br >> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c<br >> @@ -4326,7 +4326,7 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,<br >><br >>         irq_set_status_flags(te_irq, IRQ_NOAUTOEN);<br >><br >> -       err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,<br >> +       err = request_threaded_irq(te_irq | IRQF_ONESHOT, NULL, omap_dsi_te_irq_handler,<br >>                                    IRQF_TRIGGER_RISING, "TE", dsi);<br ><br >Did you test it? There are several patches like this all over the tree<br >so it looks like "let's fix everything from Coccinelle". It's a trend<br >recently... multiple people send these patches. The point is that you<br >should not blindly follow coccinelle but adjust the change for real<br >case (e.g. is it a nested interrupt). Without this consideration and<br >testing - NACK.<br ><br >Best regards,<br >Krzysztof</blockquote><div ><br ></div></div>