<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Thanks for you advice, and I <span class="Y2IQFc" lang="en">modify
the patch according to your suggestions.<br>
</span></p>
<div class="moz-cite-prefix">在 2021/8/10 下午5:59, Daniel Vetter 写道:<br>
</div>
<blockquote type="cite"
cite="mid:YRJOCzKVJOfCS4Ro@phenom.ffwll.local">
<pre class="moz-quote-pre" wrap="">On Fri, Aug 06, 2021 at 10:30:47AM +0800, zhaoxiao wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Address the following checkpatch errors:
ERROR: do not initialise statics to false
FILE: :drivers/gpu/drm/msm/msm_drv.c:21:
-static bool reglog = false;
FILE: :drivers/gpu/drm/msm/msm_drv.c:31:
-bool dumpstate = false;
Signed-off-by: zhaoxiao <a class="moz-txt-link-rfc2396E" href="mailto:zhaoxiao@uniontech.com"><zhaoxiao@uniontech.com></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Subject should start out with drm/msm, not drm/drv - that would indicate a
patch touching the drm_drv.c core files, or things related to that.
-Daniel
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">---
v2: change the patch description
drivers/gpu/drm/msm/msm_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 9b8fa2ad0d84..d9ca4bc9620b 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -59,7 +59,7 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = {
};
#ifdef CONFIG_DRM_MSM_REGISTER_LOGGING
-static bool reglog = false;
+static bool reglog;
MODULE_PARM_DESC(reglog, "Enable register read/write logging");
module_param(reglog, bool, 0600);
#else
@@ -76,7 +76,7 @@ static char *vram = "16m";
MODULE_PARM_DESC(vram, "Configure VRAM size (for devices without IOMMU/GPUMMU)");
module_param(vram, charp, 0);
-bool dumpstate = false;
+bool dumpstate;
MODULE_PARM_DESC(dumpstate, "Dump KMS state on errors");
module_param(dumpstate, bool, 0600);
--
2.20.1
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
</html>