<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;"><div>Hi Ezequiel,</div><div><br></div><div>Thanks for your suggestion.</div><div><br></div><div>On Thu, 2021-10-14 at 09:38 -0300, Ezequiel Garcia wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Hi Yunfei,</div><div><br></div><div>On Tue, 12 Oct 2021 at 22:17, <a href="mailto:yunfei.dong@mediatek.com">yunfei.dong@mediatek.com</a></div><div><<a href="mailto:yunfei.dong@mediatek.com">yunfei.dong@mediatek.com</a>> wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><div>Hi Ezequiel,</div><div><br></div><div>Thanks for your feedback,</div><div><br></div><div>The driver can work well now according to your advice with</div><div>of_platform_populate interface.</div><div><br></div><div>In order to se<font size="4"></font>parate parent node with children node, parent node is</div><div>master device, children node is component device.</div><div><br></div><div>The master and component are registered platform device.</div><div><br></div><div><br></div><div>Could you please help to review the patch again when you are free:</div><div><br></div><div><a href="https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.dong@mediatek.com/">https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.dong@mediatek.com/</a></div><div><br></div></blockquote><div><br></div><div>I'm glad you managed to simplify the driver. I tried applying the patches</div><div>but they don't apply on media master. Please push a branch to gitlab or github</div><div>or somewhere public.</div><div><br></div><div>Keep in mind that when you need people to review your code,</div><div>it's generally good practice to try to make it easy on them.</div><div>The harder you make it, the less inclined people will be to</div><div>spend time on your work.</div><div><br></div></blockquote><div>I will send the patch v8 base on media tree, and I already test it in my local environment.</div><div>And you can get media_tree then sync patch v8.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Thanks,</div><div>Ezequiel</div></blockquote><div>Thanks</div><div>Yunfei Dong</div></body></html>