<div dir="ltr">Hi Robert,<div><br><div>Sure, i have sent the v3 of this patch.</div><div>So thankful for your guidance!</div><div><br></div><div>Best Regards</div><div>Zhiming</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Robert Foss <<a href="mailto:robert.foss@linaro.org">robert.foss@linaro.org</a>> 于2022年1月17日周一 23:23写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey Zhiming,<br>
<br>
Again, I think the code is good, but let's fix some small stuff with<br>
the patch submission and then I'll happily apply this.<br>
<br>
On Thu, 13 Jan 2022 at 13:52, Zhiming Liu <<a href="mailto:lzmlzmhh@gmail.com" target="_blank">lzmlzmhh@gmail.com</a>> wrote:<br>
><br>
> Signed-off-by: Zhiming Liu <<a href="mailto:lzmlzmhh@gmail.com" target="_blank">lzmlzmhh@gmail.com</a>><br>
<br>
The tags like Signed-off-by come after the body of the commit message.<br>
<br>
><br>
> bridge : drm : Remove extra device acquisition method of i2c client in lt9611 driver.<br>
<br>
This line has to come first, since it is the title of the commit message.<br>
<br>
><br>
> We have get the device of i2c client in probe function.So we should<br>
> remove extra device acquisition method of i2c client.<br>
<br>
^^^ this is the body of the commit message.<br>
<br>
Put the tags like Signed-off-by here.<br>
<br>
> ---<br>
>  drivers/gpu/drm/bridge/lontium-lt9611.c    | 4 ++--<br>
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--<br>
>  2 files changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c<br>
> index dafb1b47c15f..feb128a4557d 100644<br>
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c<br>
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c<br>
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,<br>
>         if (!lt9611)<br>
>                 return -ENOMEM;<br>
><br>
> -       lt9611->dev = &client->dev;<br>
> +       lt9611->dev = dev;<br>
>         lt9611->client = client;<br>
>         lt9611->sleep = false;<br>
><br>
> @@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,<br>
>                 return PTR_ERR(lt9611->regmap);<br>
>         }<br>
><br>
> -       ret = lt9611_parse_dt(&client->dev, lt9611);<br>
> +       ret = lt9611_parse_dt(dev, lt9611);<br>
>         if (ret) {<br>
>                 dev_err(dev, "failed to parse device tree\n");<br>
>                 return ret;<br>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c<br>
> index 33f9716da0ee..3d62e6bf6892 100644<br>
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c<br>
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c<br>
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,<br>
>         if (!lt9611uxc)<br>
>                 return -ENOMEM;<br>
><br>
> -       lt9611uxc->dev = &client->dev;<br>
> +       lt9611uxc->dev = dev;<br>
>         lt9611uxc->client = client;<br>
>         mutex_init(&lt9611uxc->ocm_lock);<br>
><br>
> @@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,<br>
>                 return PTR_ERR(lt9611uxc->regmap);<br>
>         }<br>
><br>
> -       ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);<br>
> +       ret = lt9611uxc_parse_dt(dev, lt9611uxc);<br>
>         if (ret) {<br>
>                 dev_err(dev, "failed to parse device tree\n");<br>
>                 return ret;<br>
> --<br>
> 2.25.1<br>
><br>
</blockquote></div>