<div dir="ltr">Hi Hsin-Yi,<div><br></div><div>Got it, thanks</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 18 Feb 2022 at 17:01, Hsin-Yi Wang <<a href="mailto:hsinyi@chromium.org">hsinyi@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Feb 18, 2022 at 2:36 PM Rex Nie <<a href="mailto:rexnie3@gmail.com" target="_blank">rexnie3@gmail.com</a>> wrote:<br>
><br>
> innolux,n140hca-eac is a eDP-based LCD panel. This panel has 1920x1080<br>
> resolution in 14-inch TFT panel.<br>
><br>
> Signed-off-by: Rex Nie <<a href="mailto:rexnie3@gmail.com" target="_blank">rexnie3@gmail.com</a>><br>
> ---<br>
> .../display/panel/innolux,n140hca-eac.yaml | 43 +++++++++++++++++++<br>
> drivers/gpu/drm/panel/panel-edp.c | 26 +++++++++++<br>
> 2 files changed, 69 insertions(+)<br>
> create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,n140hca-eac.yaml<br>
><br>
Hi Rex,<br>
<br>
Please split yaml and driver into different patches.<br>
You don't need to create a new binding for innolux,n140hca-eac.yaml.<br>
You can add the compatible into panel-simple.yaml. Check<br>
innolux,n125hce-gn1 for example.<br>
<br>
> diff --git a/Documentation/devicetree/bindings/display/panel/innolux,n140hca-eac.yaml b/Documentation/devicetree/bindings/display/panel/innolux,n140hca-eac.yaml<br>
> new file mode 100644<br>
> index 000000000000..5493e383c97c<br>
> --- /dev/null<br>
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,n140hca-eac.yaml<br>
> @@ -0,0 +1,43 @@<br>
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)<br>
> +%YAML 1.2<br>
> +---<br>
> +$id: <a href="http://devicetree.org/schemas/display/panel/innolux,n140hca-eac.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/schemas/display/panel/innolux,n140hca-eac.yaml#</a><br>
> +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a><br>
> +<br>
> +title: Innolux N140HCA-EAC 14 inch eDP 1080p display panel<br>
> +<br>
> +maintainers:<br>
> + - Sandeep Panda <<a href="mailto:spanda@codeaurora.org" target="_blank">spanda@codeaurora.org</a>><br>
> + - Douglas Anderson <<a href="mailto:dianders@chromium.org" target="_blank">dianders@chromium.org</a>><br>
> +<br>
> +allOf:<br>
> + - $ref: panel-common.yaml#<br>
> +<br>
> +properties:<br>
> + compatible:<br>
> + const: innolux,n140hca-eac<br>
> +<br>
> + enable-gpios: true<br>
> + power-supply: true<br>
> + backlight: true<br>
> + no-hpd: true<br>
> +<br>
> +required:<br>
> + - compatible<br>
> + - power-supply<br>
> +<br>
> +additionalProperties: false<br>
> +<br>
> +examples:<br>
> + - |<br>
> + #include <dt-bindings/gpio/gpio.h><br>
> +<br>
> + panel_edp: panel-edp {<br>
> + compatible = "innolux,n140hca-eac";<br>
> + enable-gpios = <&pio 96 GPIO_ACTIVE_HIGH>;<br>
> + power-supply = <&pp3300_disp_x>;<br>
> + backlight = <&backlight_lcd0>;<br>
> + no-hpd;<br>
> + };<br>
> +<br>
> +...<br>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c<br>
> index f7bfcf63d48e..f5f9c9cb26ba 100644<br>
> --- a/drivers/gpu/drm/panel/panel-edp.c<br>
> +++ b/drivers/gpu/drm/panel/panel-edp.c<br>
> @@ -1330,6 +1330,29 @@ static const struct panel_desc innolux_n125hce_gn1 = {<br>
> },<br>
> };<br>
><br>
> +static const struct display_timing innolux_n140hca_eac_timing = {<br>
> + .pixelclock = { 72600000, 76420000, 80240000 },<br>
> + .hactive = { 1920, 1920, 1920 },<br>
> + .hfront_porch = { 80, 80, 80 },<br>
> + .hback_porch = { 190, 190, 190 },<br>
> + .hsync_len = { 60, 60, 60 },<br>
> + .vactive = { 1080, 1080, 1080 },<br>
> + .vfront_porch = { 6, 6, 6 },<br>
> + .vback_porch = { 38, 38, 38 },<br>
> + .vsync_len = { 8, 8, 8 },<br>
> + .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW,<br>
> +};<br>
> +<br>
> +static const struct panel_desc innolux_n140hca_eac = {<br>
> + .timings = &innolux_n140hca_eac_timing,<br>
> + .num_timings = 1,<br>
> + .bpc = 6,<br>
> + .size = {<br>
> + .width = 309,<br>
> + .height = 174,<br>
> + },<br>
> +};<br>
> +<br>
> static const struct drm_display_mode innolux_p120zdg_bf1_mode = {<br>
> .clock = 206016,<br>
> .hdisplay = 2160,<br>
> @@ -1750,6 +1773,9 @@ static const struct of_device_id platform_of_match[] = {<br>
> }, {<br>
> .compatible = "innolux,n125hce-gn1",<br>
> .data = &innolux_n125hce_gn1,<br>
> + }, {<br>
> + .compatible = "innolux,n140hca-eac",<br>
> + .data = &innolux_n140hca_eac,<br>
> }, {<br>
> .compatible = "innolux,p120zdg-bf1",<br>
> .data = &innolux_p120zdg_bf1,<br>
> --<br>
> 2.25.1<br>
><br>
</blockquote></div>