<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jun 30, 2022, at 3:51 PM, Ville Syrjala <<a href="mailto:ville.syrjala@linux.intel.com" class="">ville.syrjala@linux.intel.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">From: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" class="">ville.syrjala@linux.intel.com</a>><br class="">
<br class="">
Stop using the 'TRUE' define. This ultimately gets defined by<br class="">
acpi/actypes.h that gets included here via a convoluted chain of<br class="">
other headers. drm_crtc.h is part of that chain, and I'm trying<br class="">
to eliminate all unnecessary includes from it to avoid pointless<br class="">
rebuilds.<br class="">
<br class="">
v2: Split out from the bigger patch<br class="">
<br class="">
Cc: Zack Rusin <<a href="mailto:zackr@vmware.com" class="">zackr@vmware.com</a>><br class="">
Cc: VMware Graphics Reviewers <<a href="mailto:linux-graphics-maintainer@vmware.com" class="">linux-graphics-maintainer@vmware.com</a>><br class="">
Acked-by: Sam Ravnborg <<a href="mailto:sam@ravnborg.org" class="">sam@ravnborg.org</a>><br class="">
Acked-by: Jani Nikula <<a href="mailto:jani.nikula@intel.com" class="">jani.nikula@intel.com</a>><br class="">
Signed-off-by: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" class="">ville.syrjala@linux.intel.com</a>><br class="">
---<br class="">
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +-<br class="">
1 file changed, 1 insertion(+), 1 deletion(-)<br class="">
<br class="">
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c<br class="">
index 693028c31b6b..ff2f735bbe7a 100644<br class="">
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c<br class="">
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c<br class="">
@@ -252,7 +252,7 @@ static void vmw_cursor_update_position(struct vmw_private *dev_priv,<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_write(dev_priv, SVGA_REG_CURSOR4_Y, y);<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_write(dev_priv, SVGA_REG_CURSOR4_SCREEN_ID, SVGA3D_INVALID_ID);<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_write(dev_priv, SVGA_REG_CURSOR4_ON, svga_cursor_on);<br class="">
-<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, TRUE);<br class="">
+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, 1);<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span>} else if (vmw_is_cursor_bypass3_enabled(dev_priv)) {<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_ON, svga_cursor_on);<br class="">
<span class="Apple-tab-span" style="white-space:pre"></span><span class="Apple-tab-span" style="white-space:pre"></span>vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_X, x);<br class="">
</div>
</div>
</blockquote>
<br class="">
</div>
<div>Hi, Ville.</div>
<div><br class="">
</div>
<div>Sorry for the delay. Looks great. In case you haven’t pushed it to drm-misc-next yet:</div>
<div><br class="">
</div>
<div>Reviewed-by: Zack Rusin <<a href="mailto:zackr@vmware.com" class="">zackr@vmware.com</a>></div>
<div><br class="">
</div>
<div>z</div>
</body>
</html>