<div dir="ltr"><div>Hi Samuel,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jul 3, 2022 at 1:17 PM Samuel Holland <<a href="mailto:samuel@sholland.org">samuel@sholland.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/15/22 4:38 AM, Suniel Mahesh wrote:<br>
> Add a binding for the RenewWorldOutReach R16-Vista-E board based on<br>
> allwinner R16.<br>
> <br>
> Signed-off-by: Christopher Vollo <<a href="mailto:chris@renewoutreach.org" target="_blank">chris@renewoutreach.org</a>><br>
> Signed-off-by: Jagan Teki <<a href="mailto:jagan@amarulasolutions.com" target="_blank">jagan@amarulasolutions.com</a>><br>
> Signed-off-by: Suniel Mahesh <<a href="mailto:sunil@amarulasolutions.com" target="_blank">sunil@amarulasolutions.com</a>><br>
<br>
The primary author of the commit (the From:) should be the first signer, unless<br>
you are using Co-developed-by:. See the examples here:<br>
<br>
<a href="https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by" rel="noreferrer" target="_blank">https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by</a><br>
<br>
> ---<br>
> Changes for v2:<br>
> - Add missing compatible string<br>
> - insert missing signatures of contributors<br>
> ---<br>
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++<br>
>  1 file changed, 6 insertions(+)<br>
> <br>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml<br>
> index 95278a6a9a8e..52b8c9aba6f3 100644<br>
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml<br>
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml<br>
> @@ -787,6 +787,12 @@ properties:<br>
>            - const: allwinner,r7-tv-dongle<br>
>            - const: allwinner,sun5i-a10s<br>
>  <br>
> +      - description: RenewWorldOutreach R16-Vista-E<br>
> +        items:<br>
> +          - const: renewworldoutreach,r16-vista-e<br>
<br>
This vendor prefix should be documented.<br></blockquote><div><br></div><div>Thanks for the suggestions, sending a v3. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Regards,<br>
Samuel<br>
<br>
> +          - const: allwinner,sun8i-r16<br>
> +          - const: allwinner,sun8i-a33<br>
> +<br>
>        - description: RerVision H3-DVK<br>
>          items:<br>
>            - const: rervision,h3-dvk<br>
> <br>
<br>
</blockquote></div></div>