<div dir="auto">Thanks for review, I will resend this path.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Krzysztof Kozlowski <<a href="mailto:krzysztof.kozlowski@linaro.org">krzysztof.kozlowski@linaro.org</a>> 于 2022年12月21日周三 16:13写道：<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 21/12/2022 08:02, Jianhua Lu wrote:<br>
> Add device tree bindings for the Kinetic KTZ8866 backlight driver.<br>
<br>
1. Your patches are not properly threaded which makes it difficult to<br>
review and handle them. Resend with proper threads.<br>
<br>
2. Subject: drop second, redundant "binding for".<br>
<br>
> <br>
> Signed-off-by: Jianhua Lu <<a href="mailto:lujianhua000@gmail.com" target="_blank" rel="noreferrer">lujianhua000@gmail.com</a>><br>
> ---<br>
>  .../leds/backlight/kinetic,ktz8866.yaml       | 37 +++++++++++++++++++<br>
>  1 file changed, 37 insertions(+)<br>
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml<br>
> <br>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml<br>
> new file mode 100644<br>
> index 000000000000..7286c3fc7f5d<br>
> --- /dev/null<br>
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml<br>
> @@ -0,0 +1,37 @@<br>
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)<br>
> +%YAML 1.2<br>
> +---<br>
> +$id: <a href="http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#" rel="noreferrer noreferrer" target="_blank">http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#</a><br>
> +$schema: <a href="http://devicetree.org/meta-schemas/core.yaml#" rel="noreferrer noreferrer" target="_blank">http://devicetree.org/meta-schemas/core.yaml#</a><br>
> +<br>
> +title: Kinetic Technologies KTZ8866 backlight<br>
> +<br>
> +maintainers:<br>
> +  - Jianhua Lu <<a href="mailto:lujianhua000@gmail.com" target="_blank" rel="noreferrer">lujianhua000@gmail.com</a>><br>
> +<br>
> +description: |<br>
> +  The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight<br>
> +  with dual lcd bias power.<br>
> +  <a href="https://www.kinet-ic.com/ktz8866/" rel="noreferrer noreferrer" target="_blank">https://www.kinet-ic.com/ktz8866/</a><br>
> +<br>
> +allOf:<br>
> +  - $ref: common.yaml#<br>
> +<br>
> +properties:<br>
> +  compatible:<br>
> +    items:<br>
> +      const: kinetic,ktz8866<br>
<br>
Does not look like you tested the bindings. Please run `make<br>
dt_binding_check` (see<br>
Documentation/devicetree/bindings/writing-schema.rst for instructions).<br>
<br>
> +<br>
> +required:<br>
> +  - compatible<br>
> +<br>
> +additionalProperties: false<br>
<br>
This should be rather unevaluatedProperties: false, otherwise you do not<br>
allow any other properties, except compatible. Was this the intention?<br>
<br>
Best regards,<br>
Krzysztof<br>
<br>
</blockquote></div>