<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 26, 2023 at 10:41 AM Krzysztof Kozlowski <<a href="mailto:krzysztof.kozlowski@linaro.org">krzysztof.kozlowski@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 25/01/2023 22:09, Jonathan Cormier wrote:<br> > From: Michael Williamson <<a href="mailto:michael.williamson@criticallink.com" target="_blank">michael.williamson@criticallink.com</a>><br> > <br> > The TFP410 driver does not support I2C. As such, the device remains in<br> > Power Down if the I2C is enabled by the bootstrap pins.<br> > <br> > Add basic support for the I2C interface, and provide support to take<br> > the device out of power down when enabled. Also read the bootstrap mode<br> > pins via the CTL_1_MODE register when using the I2C bus.<br> > <br> > Signed-off-by: Michael Williamson <<a href="mailto:michael.williamson@criticallink.com" target="_blank">michael.williamson@criticallink.com</a>><br> > Signed-off-by: Jonathan Cormier <<a href="mailto:jcormier@criticallink.com" target="_blank">jcormier@criticallink.com</a>><br> > ---<br> > drivers/gpu/drm/bridge/ti-tfp410.c | 95 +++++++++++++++++++++++++++-----------<br> > 1 file changed, 68 insertions(+), 27 deletions(-)<br> <br> Use subject prefixes matching the subsystem (which you can get for<br> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory<br> your patch is touching).<br> <br> hint: it is entirely different.<br></blockquote><div>It's caps vs non caps so not entirely different. But it should be lowercase so I will fix that. Note there does seem to be some disagreement between "drm: bridge" and "drm/bridge" in the commits. The later appears slightly more often, especially recently so I will go with that.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> > <br> > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c<br> > index b9635abbad16..323a6d9ed188 100644<br> > --- a/drivers/gpu/drm/bridge/ti-tfp410.c<br> > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c<br> > @@ -6,6 +6,7 @@<br> > <br> > #include <linux/gpio/consumer.h><br> > #include <linux/i2c.h><br> > +#include <linux/regmap.h><br> > #include <linux/media-bus-format.h><br> > #include <linux/module.h><br> > #include <linux/of_graph.h><br> > @@ -21,6 +22,20 @@<br> <br> (...)<br> <br> > <br> > static void tfp410_i2c_remove(struct i2c_client *client)<br> > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids);<br> > static struct i2c_driver tfp410_i2c_driver = {<br> > .driver = {<br> > .name = "tfp410",<br> > - .of_match_table = of_match_ptr(tfp410_match),<br> > + .of_match_table = tfp410_match,<br></blockquote><div>Dropping <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> This does not look related to the patch.<br> <br> Best regards,<br> Krzysztof<br> <br> </blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Jonathan Cormier<br>Software Engineer<div><div><div><div><br></div><div><div><font color="#000000">Voice: <a value="+13154254045">315.425.4045</a> x222</font></div><div><font color="#000000"><br></font></div><div><font color="#000000"><img src="https://ci3.googleusercontent.com/mail-sig/AIorK4xml75fJPKYF7M9X5Dux4IrbtzZk0RB6jf8iBYuPQKArrkBkOkU4HJ2rP7eH6d2h7_ituMWEBc"><br></font></div></div></div><div><div><font color="#1155cc"><br></font></div><div><a href="http://www.criticallink.com/" target="_blank"><font color="#1155cc">http://www.CriticalLink.com</font></a><br></div><div>6712 Brooklawn Parkway, Syracuse, NY 13211 </div></div></div><div><div><br></div><div><font color="#1155cc"><font color="#1155cc"><a href="https://www.linkedin.com/company/critical-link-llc" target="_blank"><img src="https://docs.google.com/uc?export=download&id=0B2vNSnu-aYu6OEhHRW9BUFV5WnM&revid=0B2vNSnu-aYu6RHNZUnhNbFpER1l3emNQY2VoaHA0RDdudWlFPQ"></a> <a href="https://twitter.com/Critical_Link" target="_blank"><img alt="" src="https://docs.google.com/uc?export=download&id=0B2vNSnu-aYu6cU1yWERrLXE0SnM&revid=0B2vNSnu-aYu6b1YrZW1SM0hueVhVS0pPWm1IOXFSc0I3ay9jPQ"></a></font></font></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>