<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0 ContentPasted1"> > On 2023-05-10 15:14:16, Andi Shyti wrote: <div class="ContentPasted0">>> Hi,</div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> On Tue, May 09, 2023 at 09:59:42AM -0700, fei.yang@intel.com wrote:</div> <div class="ContentPasted0">>>> From: Fei Yang <fei.yang@intel.com></div> <div class="ContentPasted0">>>></div> <div class="ContentPasted0">>>> To comply with the design that buffer objects shall have immutable</div> <div class="ContentPasted0">>>> cache setting through out their life cycle, {set, get}_caching ioctl's</div> <div class="ContentPasted0">>>> are no longer supported from MTL onward. With that change caching</div> <div class="ContentPasted0">>>> policy can only be set at object creation time. The current code</div> <div class="ContentPasted0">>>> applies a default (platform dependent) cache setting for all objects.</div> <div class="ContentPasted0">>>> However this is not optimal for performance tuning. The patch extends</div> <div class="ContentPasted0">>>> the existing gem_create uAPI to let user set PAT index for the object</div> <div class="ContentPasted0">>>> at creation time.</div> <div class="ContentPasted0">>>> The new extension is platform independent, so UMD's can switch to using</div> <div class="ContentPasted0">>>> this extension for older platforms as well, while {set, get}_caching are</div> <div class="ContentPasted0">>>> still supported on these legacy paltforms for compatibility reason.</div> <div class="ContentPasted0">>>></div> <div class="ContentPasted0">>>> Cc: Chris Wilson <chris.p.wilson@linux.intel.com></div> <div class="ContentPasted0">>>> Cc: Matt Roper <matthew.d.roper@intel.com></div> <div class="ContentPasted0">>>> Cc: Andi Shyti <andi.shyti@linux.intel.com></div> <div class="ContentPasted0">>>> Signed-off-by: Fei Yang <fei.yang@intel.com></div> <div class="ContentPasted0">>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com></div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> just for a matter of completeness, this is new uapi is tested</div> <div class="ContentPasted0">>> through the "create-ext-set-pat" test case from the "gem_create"</div> <div class="ContentPasted0">>> igt test[1]. Can any of the igt maintainers give it a look,</div> <div class="ContentPasted0">>> comment and ack?</div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> The mesa merge request is here [2]. As there is a merge request</div> <div class="ContentPasted0">>> in progress, would anyone from mesa be so kind to give an ack to</div> <div class="ContentPasted0">>> this patch, as well?</div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> With the mesa ack in place this patch should be ready to go and</div> <div class="ContentPasted0">>> I'm looking forward to having it in.</div> <div class="ContentPasted0">></div> <div class="ContentPasted0">> I tested my MR [2] in our CI. There was some bad news, but I don't</div> <div class="ContentPasted0">> think it needs to block these patches.</div> <div class="ContentPasted0">></div> <div class="ContentPasted0">> The good news was that I found that OpenGL testing with our iris</div> <div class="ContentPasted0">> driver appeared to have ok results when using this interface.</div> > <div class="ContentPasted1">> But, our Vulkan Anvil driver was not stable with the current patches</div> <div class="ContentPasted1">> in the Mesa MR. We will need to debug this further before using the</div> <div class="ContentPasted1">> interface on Vulkan.</div> <div class="ContentPasted1">></div> <div class="ContentPasted1">> I don't suspect that this is an issue with the kernel interface, so</div> <div class="ContentPasted1">> you can add:</div> <div class="ContentPasted1">></div> <div class="ContentPasted1">> Tested-by: Jordan Justen <jordan.l.justen@intel.com></div> <div><br class="ContentPasted1"> </div> <div class="ContentPasted1">v8 sent with updates.</div> <div><br class="ContentPasted1"> </div> <div class="ContentPasted1">> -Jordan</div> <div><br class="ContentPasted1"> </div> <div class="ContentPasted1">Thanks Jordan.</div> <div><br class="ContentPasted1"> </div> <div class="ContentPasted1">>></div> <div class="ContentPasted1">>> Thanks,</div> <div class="ContentPasted1">>> Andi</div> <div class="ContentPasted1">>></div> <div class="ContentPasted1">>> [1] https://patchwork.freedesktop.org/patch/534955/?series=117185&rev=1</div> <div class="ContentPasted1">>> [2] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878</div> <div class="ContentPasted1">>></div> <br> </div> </body> </html>