<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.contentpasted0
{mso-style-name:contentpasted0;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="WordSection1">
<p class="MsoNormal">(Adding Felix in CC) <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Kent<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org>
<b>On Behalf Of </b>Ho, Kenny<br>
<b>Sent:</b> Wednesday, May 24, 2023 3:23 PM<br>
<b>To:</b> Alex Deucher <alexdeucher@gmail.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com><br>
<b>Cc:</b> Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
Daniel Vetter <daniel@ffwll.ch>; Deucher, Alexander <Alexander.Deucher@amd.com>; David Airlie <airlied@gmail.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH v2] drm/amd/display: enable more strict compile checks<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only - General]<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only - General]<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">(+ Felix)<br>
<br>
Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span class="contentpasted0"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Kenny</span></span><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>><br>
<b>Sent:</b> Wednesday, May 24, 2023 3:22 PM<br>
<b>To:</b> Mahfooz, Hamza <<a href="mailto:Hamza.Mahfooz@amd.com">Hamza.Mahfooz@amd.com</a>><br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Li, Sun peng (Leo) <<a href="mailto:Sunpeng.Li@amd.com">Sunpeng.Li@amd.com</a>>;
Ho, Kenny <<a href="mailto:Kenny.Ho@amd.com">Kenny.Ho@amd.com</a>>; Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>>; Siqueira, Rodrigo <<a href="mailto:Rodrigo.Siqueira@amd.com">Rodrigo.Siqueira@amd.com</a>>;
<a href="mailto:linux-kernel@vger.kernel.org">linux-kernel@vger.kernel.org</a> <<a href="mailto:linux-kernel@vger.kernel.org">linux-kernel@vger.kernel.org</a>>;
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a> <<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>>; Daniel Vetter <<a href="mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>>; Deucher, Alexander
<<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; David Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>>; Wentland, Harry <<a href="mailto:Harry.Wentland@amd.com">Harry.Wentland@amd.com</a>>; Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com">Christian.Koenig@amd.com</a>><br>
<b>Subject:</b> Re: [PATCH v2] drm/amd/display: enable more strict compile checks</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <<a href="mailto:hamza.mahfooz@amd.com">hamza.mahfooz@amd.com</a>> wrote:<br>
><br>
> Currently, there are quite a number of issues that are quite easy for<br>
> the CI to catch, that slip through the cracks. Among them, there are<br>
> unused variable and indentation issues. Also, we should consider all<br>
> warnings to be compile errors, since the community will eventually end<br>
> up complaining about them. So, enable -Werror, -Wunused and<br>
> -Wmisleading-indentation for all kernel builds.<br>
><br>
> Cc: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><br>
> Cc: Harry Wentland <<a href="mailto:harry.wentland@amd.com">harry.wentland@amd.com</a>><br>
> Cc: Kenny Ho <<a href="mailto:kenny.ho@amd.com">kenny.ho@amd.com</a>><br>
> Signed-off-by: Hamza Mahfooz <<a href="mailto:hamza.mahfooz@amd.com">hamza.mahfooz@amd.com</a>><br>
> ---<br>
> v2: fix grammatical error<br>
> ---<br>
> drivers/gpu/drm/amd/display/Makefile | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile<br>
> index 0d610cb376bb..3c44162ebe21 100644<br>
> --- a/drivers/gpu/drm/amd/display/Makefile<br>
> +++ b/drivers/gpu/drm/amd/display/Makefile<br>
> @@ -26,6 +26,8 @@<br>
><br>
> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)<br>
><br>
> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation<br>
> +<br>
<br>
Care to enable this for the rest of amdgpu as well? Or send out an<br>
additional patch to do that? Either way:<br>
Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><br>
<br>
Alex<br>
<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr<br>
> --<br>
> 2.40.1<br>
><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>