<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left"> [Public]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> Hi <font size="2"><span style="font-size:11pt" class="ContentPasted0">Guilherme</span></font>,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> Sorry there was one more patch which I missed to attach. Please add this 3<span><sup>rd</sup> patch and retry.</span><br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> Reverting that patch would cause high power consumption on Navi2x GPU also cause hangs on certain multi monitor configurations. With these 3 patches, you're getting the same effect as reverting the aforementioned patches, but it makes the reverted sequence available only for Steam deck hardware. <br> </div> <div class="elementToProof"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="Signature"> <div> <div></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> --</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Regards,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Jay<br> </div> </div> </div> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Guilherme G. Piccoli <gpiccoli@igalia.com><br> <b>Sent:</b> Tuesday, July 11, 2023 7:15 PM<br> <b>To:</b> Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; kernel-dev@igalia.com <kernel-dev@igalia.com>; cristian.ciocaltea@collabora.com <cristian.ciocaltea@collabora.com>; André Almeida <andrealmeid@igalia.com>; Melissa Wen <mwen@igalia.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br> <b>Subject:</b> Re: [PATCH] Revert "drm/amd/display: Program OTG vtotal min/max selectors unconditionally for DCN1+"</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On 11/07/2023 15:22, Aurabindo Pillai wrote:<br> > [...]<br> > Hi,<br> > <br> > Sorry for the delayed response, this patch went unnoticed. This revert would break asics. Could you try the attached patch without reverting this one ?<br> <br> Hi Aurabindo, thanks for your response!<br> <br> I've tried kernel 6.5-rc1, and it seems the issue is present, due to the<br> patch being merged on Linus tree [as 1598fc576420 ("drm/amd/display:<br> Program OTG vtotal min/max selectors unconditionally for DCN1+")].<br> <br> Then, I tried both your attached patches on top of that, and<br> unfortunately, the behavior is the same: Steam Deck doesn't boot with<br> graphics, and we can see the single error "amdgpu 0000:04:00.0: [drm]<br> *ERROR* [CRTC:67:crtc-0] flip_done timed out" on dmesg.<br> <br> Do you / Alex think we could get this revert for 6.5-rc2, so at least we<br> could boot mainline there while the issue is handled? It would be an<br> intermediate fix. You mentioned it breaks some asics, but did they work<br> until now, without your patch?<br> <br> Thanks,<br> <br> <br> Guilherme<br> </div> </span></font></div> </div> </body> </html>