<pre> Hi, Jason: On Mon, 2023-07-10 at 17:32 +0800, Jason-JH.Lin wrote: > According to the comment in drm_atomic_helper_async_commit(), > we should make sure FBs have been swapped, so that cleanups in the > new_state performs a cleanup in the old FB. > > So we should move swapping FBs after calling > mtk_plane_update_new_state(), > to avoid using the old FB which could be freed. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane no update") > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index 31f9420aff6f..b1a918ffe457 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -210,9 +210,9 @@ static void mtk_plane_atomic_async_update(struct > drm_plane *plane, > plane->state->src_y = new_state->src_y; > plane->state->src_h = new_state->src_h; > plane->state->src_w = new_state->src_w; > -swap(plane->state->fb, new_state->fb); > > mtk_plane_update_new_state(new_state, new_plane_state); > +swap(plane->state->fb, new_state->fb); > wmb(); /* Make sure the above parameters are set before update > */ > new_plane_state->pending.async_dirty = true; > mtk_drm_crtc_async_update(new_state->crtc, plane, state); </pre><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>