<pre>
Hi, Angelo:
On Wed, 2023-07-19 at 09:50 +0200, AngeloGioacchino Del Regno wrote:
> The .remove() callback cannot fail: switch to .remove_new() and
> change mtk_dpi_remove() to void.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index e9c5a0f44537..3a140498c98a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -1087,11 +1087,9 @@ static int mtk_dpi_probe(struct
> platform_device *pdev)
> return 0;
> }
>
> -static int mtk_dpi_remove(struct platform_device *pdev)
> +static void mtk_dpi_remove(struct platform_device *pdev)
> {
> component_del(&pdev->dev, &mtk_dpi_component_ops);
> -
> -return 0;
> }
>
> static const struct of_device_id mtk_dpi_of_ids[] = {
> @@ -1122,7 +1120,7 @@ MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>
> struct platform_driver mtk_dpi_driver = {
> .probe = mtk_dpi_probe,
> -.remove = mtk_dpi_remove,
> +.remove_new = mtk_dpi_remove,
> .driver = {
> .name = "mediatek-dpi",
> .of_match_table = mtk_dpi_of_ids,
</pre><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->