<div dir="ltr"><div dir="ltr"> </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 19, 2023 at 11:58 AM Dmitry Osipenko <<a href="mailto:dmitry.osipenko@collabora.com" target="_blank">dmitry.osipenko@collabora.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">27.06.2023 20:16, Rob Clark пишет:<br>
...<br>
>> Now these are just suggestions, and while I think they are good, you can safely ignore them.<br>
>><br>
>> But there's also the DRM requirements, which state "userspace side must be fully reviewed and tested to the standards of that user-space project.". So I think to meet the minimum requirements, I think we should at-least have one of the following (not all, just one) reviewed:<br>
>><br>
>> 1) venus using the new uapi<br>
>> 2) gfxstream vk using the new uapi<br>
>> 3) amdgpu nctx out of "draft" mode and using the new uapi.<br>
>> 4) virtio-intel using new uapi<br>
>> 5) turnip using your new uapi<br>
> <br>
> forgot to mention this earlier, but<br>
> <a href="https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533</a><br>
> <br>
> Dmitry, you can also add, if you haven't already:<br>
> <br>
> Tested-by: Rob Clark <<a href="mailto:robdclark@gmail.com" target="_blank">robdclark@gmail.com</a>><br>
<br>
Gurchetan, Turnip Mesa virtio support is ready to be merged upstream,<br>
it's using this new syncobj UAPI. Could you please give yours r-b if you<br>
don't have objections?<br></blockquote><div><br></div><div>Given that Turnip native contexts are reviewed using this UAPI, your change does now meet the requirements and is ready to merge. </div><div><br></div><div>One thing I noticed is you might need explicit padding between `num_out_syncobjs` and `in_syncobjs`. Otherwise, feel free to add my acked-by.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
Best regards,<br>
Dmitry<br>
<br>
</blockquote></div></div>