<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">2023년 8월 12일 (토) 오후 4:17, Xiang Yang <<a href="mailto:xiangyang@huaweicloud.com">xiangyang@huaweicloud.com</a>>님이 작성:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Xiang Yang <<a href="mailto:xiangyang3@huawei.com" target="_blank" rel="noreferrer">xiangyang3@huawei.com</a>><br>
<br>
Smatch reports the warning below:<br>
drivers/gpu/drm/exynos/exynos_hdmi.c:1864 hdmi_bind()<br>
error: 'crtc' dereferencing possible ERR_PTR()<br>
<br>
The return value of exynos_drm_crtc_get_by_type maybe ERR_PTR(-ENODEV),<br>
which can not be used directly. Fix this by checking the return value<br>
before using it.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Applied.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Inki Dae</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: Xiang Yang <<a href="mailto:xiangyang3@huawei.com" target="_blank" rel="noreferrer">xiangyang3@huawei.com</a>><br>
---<br>
 drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++<br>
 1 file changed, 2 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
index f3aaa4ea3e68..dd9903eab563 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
@@ -1861,6 +1861,8 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data)<br>
                return ret;<br>
<br>
        crtc = exynos_drm_crtc_get_by_type(drm_dev, EXYNOS_DISPLAY_TYPE_HDMI);<br>
+       if (IS_ERR(crtc))<br>
+               return PTR_ERR(crtc);<br>
        crtc->pipe_clk = &hdata->phy_clk;<br>
<br>
        ret = hdmi_create_connector(encoder);<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div></div></div>