<div dir="auto"><div>Hi Dave,<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">2023년 11월 24일 (금) 오전 10:14, Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>>님이 작성:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 21 Nov 2023 at 09:00, Inki Dae <<a href="mailto:inki.dae@samsung.com" target="_blank" rel="noreferrer">inki.dae@samsung.com</a>> wrote:<br>
><br>
> Hi Dave and Daniel,<br>
><br>
> Two fixups - fixing a potential error pointer dereference and wrong<br>
> error checking.<br>
Hi Inki,<br>
<br>
This fails to build on arm32, and it seems one of the fixes is wrong<br>
<br>
[airlied@dreadlord drm-fixes]$ make ARCH=arm<br>
CROSS_COMPILE=arm-linux-gnu- O=../../arm-build-fixes/ -j16<br>
make[1]: Entering directory '/home/airlied/devel/kernel/arm-build-fixes'<br>
GEN Makefile<br>
CALL /home/airlied/devel/kernel/dim/drm-fixes/scripts/checksyscalls.sh<br>
CC [M] drivers/gpu/drm/exynos/exynos_drm_dma.o<br>
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:<br>
In function ‘exynos_drm_register_dma’:<br>
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:119:40:<br>
error: passing argument 1 of ‘PTR_ERR’ makes pointer from integer<br>
without a cast [-Werror=int-conversion]<br>
119 | return PTR_ERR(-ENODEV);<br>
In file included from<br>
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/string.h:9,<br>
from<br>
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-mapping.h:7,<br>
from<br>
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-map-ops.h:9,<br>
from<br>
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:7:<br>
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/err.h:49:61:<br>
note: expected ‘const void *’ but argument is of type ‘int’<br>
49 | static inline long __must_check PTR_ERR(__force const void *ptr)<br>
| ~~~~~~~~~~~~^~~<br>
cc1: all warnings being treated as errors<br>
<br>
I think it should just be return -ENODEV, since the function returns an int.<br>
<br>
Please fix it up and resend.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Really sorry for this. Will resend after fixing it.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Inki Dae</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
Dave.<br>
<br>
<br>
<br>
><br>
> Ps. regarding the first patch, I had sent a GIT-PULL[1] but it seems<br>
> you missed.<br>
> [1] <a href="https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.dae@samsung.com/T/#u" rel="noreferrer noreferrer" target="_blank">https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.dae@samsung.com/T/#u</a><br>
><br>
> Please kindly let me know if there is any problem.<br>
><br>
> Thanks,<br>
> Inki Dae<br>
><br>
> The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263:<br>
><br>
> Linux 6.7-rc2 (2023-11-19 15:02:14 -0800)<br>
><br>
> are available in the Git repository at:<br>
><br>
> git://<a href="http://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos" rel="noreferrer noreferrer" target="_blank">git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos</a> tags/exynos-drm-fixes-for-v6.7-rc3<br>
><br>
> for you to fetch changes up to a30ba4bd7cdb5726d86a557c5df8df71c7bc7fad:<br>
><br>
> drm/exynos: fix a wrong error checking (2023-11-21 07:41:11 +0900)<br>
><br>
> ----------------------------------------------------------------<br>
> Two fixups<br>
> - Fix a potential error pointer dereference by checking the return value<br>
> of exynos_drm_crtc_get_by_type() function before accessing to crtc<br>
> object.<br>
> - Fix a wrong error checking in exynos_drm_dma.c modules, which was reported<br>
> by Dan[1]<br>
><br>
> [1] <a href="https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/" rel="noreferrer noreferrer" target="_blank">https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/</a><br>
><br>
> ----------------------------------------------------------------<br>
> Inki Dae (1):<br>
> drm/exynos: fix a wrong error checking<br>
><br>
> Xiang Yang (1):<br>
> drm/exynos: fix a potential error pointer dereference<br>
><br>
> drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++-----<br>
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++<br>
> 2 files changed, 5 insertions(+), 5 deletions(-)<br>
<br>
</blockquote></div></div></div>